Printable View
hiya i have a function which i need to use an array of card objects that i made but it says
error C2234: 'thand' : arrays of references are illegal
i have the same error for shand
here is my fn
Code:void copytosplit(card& thand[],card& shand[],int index)
When you pass an array, it will be converted to a pointer anyway, so just remove the & to indicate that it's a reference (a reference is almost the same as a pointer, but not quite).
--
Mats
so if i remove the'&' and pass the array it will still change the value after the function has finished?
or will it be the same as passing by value?
It will pass the array as a pointer to the array, so you can change the content of the array and the changes will persist after the function returns, because all that is passed is the location of where the original array is.Quote:
Originally Posted by thestien
--
Mats
Yes, since arrays are converted to pointers to their first element. What you would not be able to change is the array itself, but if you are passing a fixed size array, you cannot change the array itself anyway.Quote:
so if i remove the'&' and pass the array it will still change the value after the function has finished?
If you want to pass pointers to dynamically allocated arrays and have the function allocate the arrays, then you should use:
Code:void copytosplit(card*& thand, card*& shand, int index)
thanks guys thats really helpful :)
i have a fixed size array that would be passed to the function and need it to change the value.
but know i know it passes them as pointers anyway then that makes life easier :)
so thanks alot for the help.
eventually im going to change the arrays to vectors once ive learned how to use them would passing a vector be the same as passing an array?
Not quite, since you would pass it by reference or const reference instead of by value.Quote:
eventually im going to change the arrays to vectors once ive learned how to use them would passing a vector be the same as passing an array?
A vector isn't an array and they therefore behave differently. A vector is an object, so no pointer to its first element is passed. The entire object itself is passed, so it works just like any other non-array type. You simply pass it by reference.
oh super thats good to hear :) one day ill learn how to use pointers properly then i wont need to pass by reference then right?
C++ devs always prefer passing by reference if possible. I'd suggest you learn both things, because references are so much easier than pointers.
oh ok thanks for the advice :) its just in a book i got it says its better to pass by pointer but i must admit it sure is easy to pass most things by ref :)
The book is wrong. I would say it's far better to pass by reference, if possible (as would many others I think).
ok cool ty ill keep that in mind :)
i seem to have another problem now
i get 2 errorsCode:if (checksplit(a.myHand[])==true)
{ some other code here
: error C2059: syntax error : ']'
error C2143: syntax error : missing ';' before '{'
anyidea how to fix that?
oh by the way this function is called inside another function could that be the problem?
You probably need to call it like this:
Operator[] is used to access items, not to tell the compiler what a.myHand is. The compiler already knows what it is.Code:if (checksplit(a.myHand)==true)
{ some other code here