Word counting

<<mod note: split from 2 year old thread>>

Code:

---

#include<stdio.h>
#include<conio.h>
#include<string.h>
main()
{
clrscr();
char *str,a[]=".!?";
int index,cnt,sntcnt=0,slen=0;
printf("Enter string: ");
gets(str);
slen=strlen(str);
for (index=0;index<slen;index++)
    {
    for (cnt=0;cnt<4;cnt++)
        {
        if (str[index]==a[cnt]||str[index]=='\0')
            {
            sntcnt;
            }
        }
    }
printf("Number of sentence in the string: %d",sntcnt);
getch();
return 0;
}




#include<stdio.h>
#include<conio.h>
#include<string.h>
main()
{
clrscr();
char *str;
int index,slen=0,wrdcnt=0;
printf("Enter string: ");
gets(str);
slen=strlen(str);
for (index=0;index<=slen;index++)
    {
    if (str[index]==' '||str[index]==','||str[index]=='.'||str[index]=='!'||str[index]=='?'||str[index]=='\0')
        {
        wrdcnt++;
        if (str[index]==' ')
            {
            wrdcnt--;
            }
        else
            {
            wrdcnt++;
            }
        }
    }
printf("The number of words in the string is: %d",wrdcnt);
getch();
return 0;
}

---

yea these are the codes i have..it works kinda ok but it just counts as the condition applies...im having trouble trying to figure out the problem with this...can provide some help pls..im really new to this...

From the forum rules.

Quote:

---

Please follow the forum structure when posting. Post threads on the board best suited for the topic. Please do not cross post (i.e. post the same question on multiple boards). Do not bump threads. (Bumping: Posting messages on threads to move them up the list or to post on a thread that has been inactive for two weeks or longer).

---

You should have read the other thread, not bumped it.

char *str;
gets(str);

The absolute worst two lines of C you'll ever see.
str is uninitialised - you've no idea where your input is going to go
gets() is unconstrained - you've no idea how much input is going to an unknown place.

Read the FAQ, and ALWAYS use fgets()
Eg
char buff[100];
fgets( buff, sizeof(buff), stdin );