pointer display data problem

hi all,
see the following code:

Code:

---


for (int i=0; i<=10; i++){
       

if(data.gettxt(i).Find(editbxtxt)>=0){

CString *p = new CString[80];
p = new CString(details);

resultlist result;
result.buffer= p;

p++;
}


//result dialog:
for((int i=0; i<=10; i++){
list.addstring(*buffer);
buffer++
}

---

is there any wrong with my code?since the list only display the last result, and some additional strange character row. anyone know why is that? thanks!!

I think you want to move the bolded part outside the for loop.

Code:

---


for (int i=0; i<=10; i++){
    if(data.gettxt(i).Find(editbxtxt)>=0){
    CString *p = new CString[80];
    p = new CString(details);
    resultlist result;
    result.buffer= p;
    p++;
}

//result dialog:
for((int i=0; i<=10; i++){
list.addstring(*buffer);
buffer++
}

---

Also, you should have use a second pointer to store the value returned by new so you can delete it later.

i've moved that part outside but the result is ame as before, what's the right code for that?
thx!

I would hazard a guess that the "additional strange character row" is because you loop one more time than needed due to an incorrect loop condition, i.e., instead of:

Code:

---

for (int i=0; i<=10; i++){

---

you should write:

Code:

---

for (int i=0; i<10; i++){

---

Other than that, I suggest posting a little more code, copied from your actual code. Your current code example has syntax errors and so should not even compile.

Are you sure that you really want an array of CString objects in the first place and not something like

scoped_array< char > p ( new char[80] );

or even

string p; ?

What you've got appears to lack a lot of sense.

Quote:

---

Originally Posted by citizen

Are you sure that you really want an array of CString objects in the first place and not something like

scoped_array< char > p ( new char[80] );

or even

string p; ?

What you've got appears to lack a lot of sense.

---

why i use these code since if not using pointer and new and got the searching so slow and overflow if the loop increase to 200. is that pointer and dynamic memory avoid overflow and search faster, isn't it?
thanks!

A scoped array is an array of objects that deletes itself when it goes out of scope. You would have to treat it like any other array. Overflowing the reserved space is an issue though. You can find an implementation in boost's libraries.

OTOH, a std::string is a STL data type for text data, and resizes itself, only making sure that there is at least enough space for the text.

As to what you really need: it looks like you are only using one CString object, which makes me wonder why you allocated an array of them. So a simple string variable looks to be more efficient.

Quote:

---

Originally Posted by mr_empty

hi all,
see the following code:

Code:

---

for (int i=0; i<=10; i++){
        if(data.gettxt(i).Find(editbxtxt)>=0){
                CString *p = new CString[80];
                p = new CString(details);
                resultlist result;
                result.buffer= p;
                p++;
        }

        //result dialog:
        for((int i=0; i<=10; i++){
                list.addstring(*buffer);
                buffer++
        }

---

is there any wrong with my code?since the list only display the last result, and some additional strange character row. anyone know why is that? thanks!!

---

Oops! Indentation error!
That's why we typically indent our code properly to make sure it works.

Your code is so flawed and doesn't match that it really doesn't make sense to optimize it. Post your real code instead.