Scanning chars, ints, doubles and char arrays

So i have a program that asks the user a command (a letter) to run a specific method, it can be just the letter, a letter and some numbers, or a letter and another word, right now i have this:

Code:

---


char com;
char col [6];
char name [MAXELEMENTS];
int a, b;
double c;

  while(scanf(" %c", &com) == 1 && com != 'q'){
    if(com == 'p'){
        list(matrix);
        }
    else if(com == 'a'){
        scanf("%d %d %lf", &a, &b, &c);
            adds(a, b, c, matrix);
    }
    else if(com == 'i'){
        carac(matrix);
    }
    else if(com == 'l'){
        scanf("%d", &a);
        printLine(a, matrix);
    }
    else if(com == 'c'){
        scanf("%d", &a);
        printColumn(a, matrix);
    }
    else if(com == 'z'){
        scanf("%lf", &c);
        zero(c, matrix);
    }
    else if(com == 'o'){
        if((scanf("%s", col)) == 1)
        sortColumn(matrix);
    else if((scanf("%s", col)) == 0)
        sortLine(matrix);
    }
    else if(com == 'w'){
        if((scanf("%s", name)) == 1)
        ficheiro(name, matrix);
        else if((scanf("%s", name)) == 0)
        ficheiroNovo(matrix);
    }
    }

---

So i´m having trouble in the commands "o" and "w". On "o" you are supposed to have the option to just type "o" and it should run the method sortLine or you type the "o column" and it runs sortColumn. On "w" the same concept, you just type "w" and it runs ficheiroNovo or you type "w" plus a name and it should run ficheiro. The thing is i can´t just type "o" or "w", it always asks for another input and always runs the sortColumn or ficheiro. Does anyone know what´s wrong anc can someone help me?

That happens because scanf is called twice inside 'o' and 'w'. If you want to check the return value of scanf, call it once and then use the saved value on multiple if statements.

Although, it still wouldn't work as you wanted, because scanf would not return zero unless it failed to read anything (for example, when the user pressed Ctrl-D or Ctrl-Z).

What you really want to do is read the whole line beforehand and scan it manually, with sscanf.

I got to this point:

Code:

---


char input[82];
char col [6];
char name [MAXCARAC];
unsigned int a, b;
double c;

if(fgets(input, sizeof(input), stdin)){
        if(input[0] == 'q' && input[1] == '\n' && input[2] == '\0'){
            return -1;
        }
     
        if(input[0] == 'p' && input[1] == '\n' && input[2] == '\0'){
            list(matrix);
        }
        else if(input[0] == 'i' && input[1] == '\n' && input[2] == '\0'){
            carac(matrix);
        }
        else if((sscanf(input, "%c %u %u %lf\n", &input[0], &a, &b ,&c) == 4)){
            adds(a, b, c, matrix);
        }
        else if(input[0] == 'l' && (sscanf(input, "%u\n", &a) == 1)){
            printLine(a , matrix);
        }
        else if(input[0] == 'c' && (sscanf(input, "%u\n", &a) == 1)){
            printColumn(a , matrix);
        }
        else if(input[0] == 'z' && (sscanf(input, "%u\n", &a) == 1)){
            zero(a , matrix);
        }
        else if(input[0] == 'o' && input[1] == '\n' && input[2] == '\0'){
            sortLine(matrix);
        }
        if(input[0] == 'o' && (sscanf(input, "%s\n", col) == 1) ){
            sortColumn(matrix);
        }
        else if(input[0] == 'w' && input[1] == '\n' && input[2] == '\0'){
            file(matrix);
        }
        if(input[0] == 'w' && (sscanf(input, "%s\n", name) == 1) ){
            newFile(name, matrix);
        }

     

           
    }

---

But im struggling with the "q" command that is supposed to exit the program... any advice on how i should do it?

Get rid of the [first] if and change to using a loop.
I would suggest an while or do/while loop

I would also add a statement before the fgets() call setting input[0] to zero.
But, that is partly a style code decision.
Another partly a style code decision is to use a switch statement instead of a big if statement.

Tim S.

Unless you have a specific reason for avoiding them, you should use the string functions, strcmp() in particular, when comparing multiple characters in a row.

About your question, there are many ways to exit the program, it depends on what you want to do.
*) exit() function
*) return from main
*) return a specific value from the function to check for
*) if inside a loop, set the looping flag to false

Like this?

Code:

---


char input[82];
char col [6];
char name [MAXCARAC];
unsigned int a, b;
double c;

if(fgets(input, sizeof(input), stdin)){
    while(input[0] != 'q'){
        if(input[0] == 'p' && input[1] == '\n' && input[2] == '\0'){
            list(matrix);
        }
        else if(input[0] == 'i' && input[1] == '\n' && input[2] == '\0'){
            carac(matrix);
        }
        else if((sscanf(input, "%c %u %u %lf\n", &input[0], &a, &b ,&c) == 4)){
            adds(a, b, c, matrix);
        }
        else if(input[0] == 'l' && (sscanf(input, "%u\n", &a) == 1)){
            printLine(a , matrix);
        }
        else if(input[0] == 'c' && (sscanf(input, "%u\n", &a) == 1)){
            printColumn(a , matrix);
        }
        else if(input[0] == 'z' && (sscanf(input, "%u\n", &a) == 1)){
            zero(a , matrix);
        }
        else if(input[0] == 'o' && input[1] == '\n' && input[2] == '\0'){
            sortLine(matrix);
        }
        if(input[0] == 'o' && (sscanf(input, "%s\n", col) == 1) ){
            sortColumn(matrix);
        }
        else if(input[0] == 'w' && input[1] == '\n' && input[2] == '\0'){
            file(matrix);
        }
        if(input[0] == 'w' && (sscanf(input, "%s\n", name) == 1) ){
            newFile(name, matrix);
        }




    }

---

I already tried it, but the first command i type keeps running non stop

I think the while loop should be outside/above the if statement.

Thanks a lot, the "w" and "o" commands are working, but the "l", "c" and "z" aren´t doing anything, is something wrong with those ifs?

Yes, it's the hazards of copying and pasting. You need to skip the first character in those scanf calls.