Newbie question: Help with these if statements?

The following program i have write but i get a problem.

If i use single if for each team and whatever string i write it gets values from the last team.

if i use else if i get values from the first team.

How i shall write it to get the potion value from the right team for the string i type.
Something i miss, but i cant figure it out

Code:

void do_create_potion( CHAR_DATA* ch, const char* argument) { OBJ_DATA *ingredient; OBJ_DATA *potion; int selection; int dice; int check; dice = number_percent(); check = LEARNED(ch, gsn_create_potion) + (get_curr_int(ch)/2); ingredient = get_obj_carry(ch, argument); selection = rand() %3; if(argument[0] == '\0' || !str_cmp(argument, "")) { send_to_char( "Brew what?\r\n", ch ); return; } if(str_cmp(argument, "alit hide")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_INTELLIGENCE), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_POISON_RESISTANCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_PICKPOCKET), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_DETECT_INVISIBILITY), 0);} } if(str_cmp(argument, "ampoule pod")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_WATER_BREATHING), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_PARALYSIS), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DETECT_INVISIBILITY), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_WILLPOWER), 0);} } if(str_cmp(argument, "ash salts")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_AGILITY), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_MAGIC_RESISTANCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DISEASE_IMMUNITY), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_RESTORE_MAGICKA), 0);} } if(str_cmp(argument, "ash yam")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_INTELLIGENCE), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_STRENGTH), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DISEASE_RESISTANCE), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_SNEAK), 0);} } if(str_cmp(argument, "bittergreen petals")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_RESTORE_INTELLIGENCE), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_INVISIBILITY), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_ENDURANCE), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_MAGICKA), 0);} } if(str_cmp(argument, "black anther")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_AGILITY), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FIRE_RESISTANCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_ENDURANCE), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_ALCHEMY), 0);} } if(str_cmp(argument, "black lichen")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_STRENGTH), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FROST_RESISTANCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_AGILITY), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_POISON_IMMUNITY), 0);} } if(str_cmp(argument, "bloat")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_MAGICKA), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_INTELLIGENCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_WILLPOWER), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_DETECT_INVISIBILITY), 0);} } if(str_cmp(argument, "bonemeal")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_RESTORE_AGILITY), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_PICKPOCKET), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_FATIGUE), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_PERSONALITY), 0);} } if(str_cmp(argument, "corkbulb root")) { if(selection == 0) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_AGILITY), 0);} if(selection == 1) {potion = create_object(get_obj_index(OBJ_POTION_FIRE_RESISTANCE), 0);} if(selection == 2) {potion = create_object(get_obj_index(OBJ_POTION_DRAIN_ENDURANCE), 0);} if(selection == 3) {potion = create_object(get_obj_index(OBJ_POTION_FORTIFY_ALCHEMY), 0);} } if(check < dice) { if(ingredient != NULL) { ch_printf( ch, "You brew a %s.\r\n", potion->name); obj_to_char(potion, ch); extract_obj(ingredient); learn_from_success(ch, gsn_create_potion); } else { send_to_char( "You don't have this ingredient.\r\n", ch ); } } else { ch_printf( ch, "You failed brewing.\r\n"); extract_obj(ingredient); } }

You might find it more maintainable to put the data into tables in the form of arrays that you then iterate over. For example:

Code:

static const int obj_indices[][4] = { {OBJ_POTION_DRAIN_INTELLIGENCE, OBJ_POTION_POISON_RESISTANCE, OBJ_POTION_FORTIFY_PICKPOCKET, OBJ_POTION_DETECT_INVISIBILITY}, // alit hide {OBJ_POTION_WATER_BREATHING, OBJ_POTION_PARALYSIS, OBJ_POTION_DETECT_INVISIBILITY, OBJ_POTION_DRAIN_WILLPOWER}, // ampoule pod {OBJ_POTION_DRAIN_AGILITY, OBJ_POTION_MAGIC_RESISTANCE, OBJ_POTION_DISEASE_IMMUNITY, OBJ_POTION_RESTORE_MAGICKA} // ash salts }; static const char *ingredient_names[] = { "alit hide", "ampoule pod", "ash salts" } if (argument[0] == '\0' || strcmp(argument, "") == 0) { send_to_char("Brew what?\r\n", ch); return; } selection = rand() % 3; potion = NULL; for (size_t i = 0; i < sizeof(ingredient_names) / sizeof(ingredient_names[0]); ++i) { if (strcmp(argument, ingredient_names[i]) == 0) { potion = create_object(get_obj_index(obj_indices[i][selection]), 0); break; } }

Unless argument has domain-specific meaning in this apparent game of yours, you should not use it as a parameter name. From what I see, ingredient_name might be a more descriptive name for that parameter.

Also, instead of rand() % 3, you probably want to write rand() % 4, and that 4 should be a named constant that's also used to define obj_indices.

I have changed your use of str_cmp to strcmp; if you really do have your own str_cmp function that is preferable for some reason you can of course switch it back. I suspect that your str_cmp returns a boolean true for equal, in which case you might want to rename str_cmp to something like equal_str because str_cmp can easily be confused with strcmp that has very different semantics, and then there is some issue with the str prefix being reserved to the implementation.

Hello friend, thanks for answer.
It compiles without errors but it crashes when i try to brew a potion (run the script)

By my little knowdge this happens because of
if (strcmp(argument, ingredient_names[i]) == 0)

This requires the excact word to be written. Because this is made for an multiplayer game, and maybe not everyone will write the whole word and it cause the program to crash.

For example if i type brew ampoule pod it does the work as intented, but if i write brew ampoule it crashes.

That's why I set potion to be NULL just before the loop. This gives you a way to check if the potion was brewed at all. If it wasn't (i.e., it remains NULL after the loop), you would find a way to inform the player to try again instead.