Bit Fields

I am having trouble printing the dates from a binary file. Here is the table that I am using for reference:
Attachment 15666

Here is my code:

Code:

---

#include <stdio.h>


struct MiscBits
{
    unsigned id: 2;
    unsigned category: 2;
    unsigned engaged : 1;
    unsigned reserved: 3;
};


struct Date {


    unsigned year: 7;
    unsigned month: 4;
    unsigned day: 5;


    unsigned hour: 5;
    unsigned minute: 6;
    unsigned reserved2: 5;


    unsigned second: 6;
    unsigned reserved3: 10;
};


struct Record {
    float latitude;
    float longitude;
    short altitude;
    char name[5];
    struct MiscBits Misc;
    char Reported[6];
    struct Date myDate;
} __attribute__((packed));




int main(){


    FILE *file;
    struct Record myRecord;
    file = fopen("tracks2.dat", "rb");


    for(int i=0;i<4;i++) {
        fread(&myRecord,22,1,file);
        printf("latitude: %f longitude: %f altitude: %d name: %s ", myRecord.latitude,myRecord.longitude,myRecord.altitude,myRecord.name);
       
        printf("%d %d %d %d %d %d %d %d", myRecord.myDate.year, myRecord.myDate.month, myRecord.myDate.day, myRecord.myDate.hour, myRecord.myDate.minute, myRecord.myDate.second);
        switch (myRecord.Misc.id) {
            case 0: printf("%s ", "ID: Uknown");
                break;
            case 1: printf("%s ", "ID: Friend");
                break;
            case 2: printf("%s ", "ID: Foe");
                break;
            case 3: printf("%s ", "ID: Neutral");
                break;
        }
        switch (myRecord.Misc.category) {
            case 0: printf("%s ", "Category: Ship");
                break;
            case 1: printf("%s ", "Category: Ground vehicle");
                break;
            case 2: printf("%s ", "Category: Airplane");
                break;
        }
        switch (myRecord.Misc.engaged){
            case 0: printf("%s\n ", "Not Engaged");
                break;
            case 1: printf("%s\n ", "Engaged");
                break;
        }
    }
    fclose(file);
    return(0);
}

---

My program prints the other structs out correctly but not the date struct.

Update: I removed line 37 and moved line 56 to after all the switch statements but still incorrect output.

Try

Code:

---

fread(&myRecord, sizeof myRecord, 1, file);

---

You could also try reading the file more carefully, a field at a time, and extracting the bits manually.
This is totally untested so you may need to fix some things.

Code:

---

#include <stdint.h>    // compile as -std=c99
 
float latitude, longitude;
uint16_t altitude;
 
fread(&latitude,  sizeof latitude,  1, file);
fread(&longitude, sizeof longitude, 1, file);
fread(&altitude,  sizeof altitude,  1, file);    // print like printf("%d\n", (int)altitude);
 
char name[6];
fread(name, sizeof name - 1, 1, file);
name[sizeof name - 1] = '\0';
 
uint8_t b0;
fread(&b0, sizeof b0, 1, file);
 
int id      =  b0      & 0x03;
int category = (b0 >> 2) & 0x03;
int engaged  = (b0 >> 4) & 0x01;
int res1    = (b0 >> 5);
 
char reported[7];
fread(reported, sizeof reported - 1, 1, file);
name[sizeof reported - 1] = '\0';
 
uint16_t w0, w1, w2;
fread(&w0, sizeof w0, 1, file);
fread(&w1, sizeof w1, 1, file);
fread(&w2, sizeof w2, 1, file);
 
int year  =  w0        & 0x7f;
int month  = (w0 >>  7) & 0x0f;
int day    = (w0 >> 11);
int hour  =  w1        & 0x1f;
int minute = (w1 >>  5) & 0x3f;
int res2  = (w1 >> 11);
int second =  w2        & 0x3f;
int res3  = (w2 >>  6);

---

It's also possible that w0, w1, and w2 should be read in the opposite order:

Code:

---

fread(&w2, sizeof w2, 1, file);
fread(&w1, sizeof w1, 1, file);
fread(&w0, sizeof w0, 1, file);

---

The first assignment/task was to extract the bits manually. I have to use bit fields now to extract the memory. And I know the size of the record, so I don't think I need the sizeof function.

Quote:

---

Originally Posted by Marcusrogers23

And I know the size of the record, so I don't think I need the sizeof function.

---

You should still use sizeof instead of hardcoding a magic number.

hahah, thank you for taking the time to try and help though!

> I have to use bit fields now to extract the memory.
The ordering of bitfields is implementation defined.

Code:

---

struct foo {
    int field : 6;
};

---

Assume for the moment that the allocated storage unit is a short int (for clarity).
There is nothing in the standard which says that you would end up with these bits.
???????? ??xxxxxx

It is also perfectly acceptable for your compiler to choose to do this.
xxxxxx?? ????????

Having read a date, you could try this bit of debugging to see if your date bits make any sense just after reading them in.

Code:

---

unsigned short foo[3];  // same size as Date
memcpy(foo,&myRecord.myDate,3);
printf("Date Bits=%04x %04x %04x\n", foo[0],foo[1],foo[2]);

---

You can then also use the same idea to explore how your bitfields are packed.

Code:

---

memset(&myRecord,0,sizeof(myRecord);
myRecord.year = ~0;  // set all the bits for year
memcpy(foo,&myRecord.myDate,3);
printf("Date Bits=%04x %04x %04x\n", foo[0],foo[1],foo[2]);

---

The hypothesis is that foo[0] should be 0x007f.