scanf is skipped in the run window

In the below written program,
when i run it , it skips scanf and not allowing user to enter input.
tried adding getchar(), fflush but nothing worked for me.
can any one help me with this please.

program code starts from here

//file name : sort_array_of_structure.c

Code:

---


/*Write a program to accept records of the different states using array of structures. The structure should contain char state, population, literacy rate, and income. Display the state whose literacy rate is highest and whose income is highest.*/


#include <stdio.h>
#define M 50
struct state
{
    char name[50];
    long int population;
    float literacyRate;
    float income;
}st[M]; /*array of structure*/
int main()
 {


 int i, n, ml, mi, maximumLiteracyRate, maximumIncome;
 float rate;
 ml = mi = -1;
 maximumLiteracyRate = maximumIncome = 1;


 printf("Enter how many states:");
 scanf("%d", n);
 for (i = 1; i < n; i++)
    {
      printf("\nEnter state %d details : ",i);


      printf("\nEnter state name: ");
      scanf("%s",&st[i].name);


      printf("\nEnter total population : ");
      scanf("%d",&st[i].population);


      printf("\nEnter total literacy rate : ");
      scanf("%.2f",&rate);
      st[i].literacyRate = rate;
     
      printf("\nEnter total income : ");
      scanf("%f",&st[i].income);
      }


 for (i = 1; i < n; i++)
 {
      if(st[i].literacyRate >= maximumLiteracyRate)
          {
          maximumLiteracyRate = st[i].literacyRate;
          ml++;
          }


      if(st[i].income > maximumIncome)
          {
          maximumIncome = st[i].income;
          mi++;
          }
 }
 printf("\nState with highest literacy rate : %s",st[ml].name);
 printf("\nState with highest income : %s", st[mi].name);


 return(0);
 }

---

increase your warning level

line 24 - missing & in scanf
line 31 - & in scanf should be removed

Hey vart,

Thank you for your help.
i made changes as you said and it worked
thank you very much.

Code:

---

printf("Enter how many states:");
 scanf("%d", &n);
 for (i = 1; i < n; i++)

---

Assume you enter 2 for the number of states... this loop will start with i equal to 1. Is 1 less than 2? Yes, continue with loop body. Next time through the variable i will be 2. Is 2 less than 2? No, therefore exit the loop.

This loop will execute n-1 times because of your loop condition. If the user entered 1 for whatever reason then your program would skip the remaining user entry and determination of max literacy/income and go right to the output; which, since mi and ml are -1, would attempt to access memory for st[-1]. This would be bad.

I would instead suggest:

Code:

---

for (i = 0; i < n; i++)

---

... along with checks to make sure what the user enters for n is <= M and > 1.