Missing something

I think I have been working on this too long.....in the Main Function area I can't get this to work, I am sure it is probably something simple but I am not seeing it, are you???
Thanks!!!!

Code:

---


#include <iostream.h>
#include <string.h>
//----------Node Class-------------//
class Digit {
    friend class NumberList;
 
public:
    Digit( const int & );
    int getData() const;
 
private:
    int data;
    Digit *nextPtr;
 
};
 
Digit::Digit( const int &info )
  : data( info ),
    nextPtr( 0 )
{

}
 
int Digit::getData() const
{
    return data; 
}

//-----------NumberList Class ------------------//
class NumberList{
 
public:
    NumberList();
    ~NumberList();
    void insertAtBack( const int & );
    bool isEmpty() const;
    void display() const;
    void HighInt();
    void LowInt();
    void AverageInt();
 
private:
    Digit *firstPtr;
    Digit *lastPtr;
 
    Digit *getNewNode( const int & );
};
 
NumberList::NumberList()
  : firstPtr( 0 ),
    lastPtr( 0 )
{

}
 
NumberList::~NumberList()
{
    if ( !isEmpty() ) {
         
 
          Digit *currentPtr = firstPtr;
          Digit *tempPtr;
 
          while ( currentPtr != 0 )
          {
              tempPtr = currentPtr;
             
              currentPtr = currentPtr->nextPtr;
              delete tempPtr;
          }
    }
   
}
 
void NumberList::insertAtBack( const int &value )
{
    Digit *newPtr = getNewNode( value );
 
    if ( isEmpty() )
          firstPtr = lastPtr = newPtr;
      else
    {
          lastPtr->nextPtr = newPtr;
          lastPtr = newPtr;
    }
}
 
bool NumberList::isEmpty() const
{
    return firstPtr == 0; 
}
 
Digit *NumberList::getNewNode( const int &value )
{
    return new Digit( value );
}
 
void NumberList::display() const
{
    if ( isEmpty() )
    {
          cout << "The list is empty\n\n";
          return;
      }
 
      Digit *currentPtr = firstPtr;
 
    while ( currentPtr != 0 )
    {
          cout << currentPtr->data << " ";
          currentPtr = currentPtr->nextPtr;
    }
    cout << "\n\n";
}

void NumberList::AverageInt()
{
    if( isEmpty() )
    {cout << "The list is empty" << endl;}

    int length = 0;

    Digit *currentPtr = firstPtr;
    int sum = 0;

    while(currentPtr != 0)
    {
          length++;
          sum+=currentPtr->data;
          currentPtr = currentPtr->nextPtr;         
    }
    cout << "The average is " << (float)sum/length << endl;
}

void NumberList::HighInt()
{
    if( isEmpty() )
    {cout << "The list is empty" << endl;}

    Digit *currentPtr = firstPtr;

    int high = currentPtr->data;

    while(currentPtr != 0)
    {
          if(currentPtr->data > high)
          {high = currentPtr->data;}
          currentPtr = currentPtr->nextPtr;
    }
    cout << "The high is " << high << endl;
}

void NumberList::LowInt()
{
    if( isEmpty() )
    {cout << "The list is empty" << endl;}

    Digit *currentPtr = firstPtr;
    int low = currentPtr->data;

    while(currentPtr != 0)
    {
          if(currentPtr->data < low)
          {low = currentPtr->data;}
          currentPtr = currentPtr->nextPtr;
    }
    cout << "The low is " << low << endl;
}
 
//---------------main function---------------//
void main()
{
 int input;       
 int getInput(int *input);

    int n = 0;

    while(n != 9999)
    {
        cout << "Enter #" << n << " => ";
        cin >> input[i];
        if (input[i] == -1) break;
        i++;
    }

    return (n - 1);
}

---

What is going wrong.
Just looking at the main, I see that you need 'int main'. That is standard, and you also return an int. And, 'n' is never incremented. Also, you may just want an infinite loop ('while(1) or while(true) or for(;;)' ), instead of imposing an arbitrary limit (which is infinite anyway since 'n; never changes).

>I can't get this to work
Posting a bunch of code and a vague "it doesn't work!" comment won't get you very good results. Describe why it doesn't work, and what you expect it to do that it isn't doing. What is it doing that's so wrong?

I did say in the main() function is where the problem is. I am getting a few errors. I altered the code some.......

Code:

---


int main()
{
     
 int getInput(int *input);

    int n = 0;

    while(n != 9999)
    {
        cout << "Enter #" << n << " => ";
        cin >> input[n];
        if (input[n] == -1) break;
        n++;
    }

    (n - 1);
    return 0;
}

---

I am getting 2 errors, unidentified identifier 'input'.
Any ideas? Thanks!!

Quote:

---

Originally Posted by campermama

Code:

---

     
 int getInput(int *input);

---

I am getting 2 errors, unidentified identifier 'input'.
Any ideas? Thanks!!

---

Am i even qualified to answer this?

You might want to think about adding some arguments to those functions as well so you at least know what you need to pass too them when you get around to calling them.

Describe exactly what you want to accomplish. From the code you posted I could easily take it two different directions both which will be very fugly.

So far:

Code:

---

int main()  // Much better
{
     
 int getInput(int *input); //Here you are prototyping a function inside of main().
// IIRC this is legal but probably not what you want and is the source of your confusion

    int n = 0;

    while(n != 9999)
    {
        cout << "Enter #" << n << " => ";
        cin >> input[n];
        if (input[n] == -1) break;
        n++;
    }

    (n - 1); //Completly useless instruction
    return 0;
}

---