My program crashes :|

And I don't know why. I'm a bit of a newbie to coding and I know some C/C++.
I'm playing around with classes and objects, trying to get the hang of them, so I'm trying to create a database that keeps records of students-their ID number, their first and last names, and their mark. This worked fine, until I introduced a feature to allow the user to enter an ID number to look up a student, and for some reason my program crashes after displaying "ID number " with an error message.
So, without further ado, here is my code. Sorry if I've posted more than was nessesary, but feedback on what how I've done any thing would be appreciated :)

Code:

---

#include <iostream>
using namespace std;
class student
{
    public:
    int id,mark;
    char fname[20],lname[20],grade;
    void assignfname()
    {
        cout << "Enter the pupil's first name" << endl;
        cin >> fname;
    };
    void assignlname()
    {
        cout << "Enter the pupil's last name" << endl;
        cin >> lname;
    };
    void assignid()
    {
        cout << "Enter the studant's I.D. number" << endl;
        cin >> id;
    };
    void marki()
    {
        cout << "Input the pupil's mark" << endl;
        cin >> mark;
    };
    void display()
    {
        cout << "I.D.      \t" << id << endl;
        cout << "First name\t" << fname << endl;
        cout << "Last name \t" << lname << endl;
        cout << "Mark      \t" << mark << endl;
    }
};

int main()
{
    int db;
    student studentdb[1000];
    for(int x=0;x<2;x++)
    {
        studentdb[x].assignfname();
        studentdb[x].assignlname();
        studentdb[x].assignid();
        studentdb[x].marki(); 
        system("cls");
    }
    cout << "Enter the id number of the database you wish to view" << endl;
    cin >> db;
    studentdb[db].display();
    system("PAUSE");
}

---

Thanks in advance! :)

you have colon's after the }'s. Delete them. Except for the one after the entire class definition.

Code:

---

class A
{
  function B { ...do something; }
};

---

Well, the id number recorded of the student is different from the "the id number of the database you wish to view". You should be searching the array (the used portion of the array) for the student with the requested id number.

Do'h!
Would I do that with some if/elses?
And thanks for the suggestion, indigo, I've deleted those semi-colons.

Quote:

---

Would I do that with some if/elses?

---

With only two entries that approach will work. With all 1000 possible entries, I fear that you will find that rather tedious. Use a loop.

Hmm. Code is as above, but I added this do loop:

Code:

---

cout << "Enter the id number of the database you wish to view" << endl;
    cin >> db;
    for(int x=0;x<2;x++)
    {
        if(studentdb[x].id=db)
        {
            studentdb[x].display();
            break; 
        } 
    }

---

Problem is, it only displays the ID number I entered, the other variables displayed are the ones in the first element. What causes this?

Use ==, not = to do comparisons.

Gah!
I'm such a noob :( Thanks.

Firstly:

Code:

---

if(studentdb[x].id == db) // comparison: == NOT =

---

Why it only displays the ID is a question to me too.

Edit: MacGyver beats everyone!

Because of the single =, it's equivalent to this.

Code:

---

    for(int x=0;x<2;x++)
    {
        studentdb[x].id=db;
        if(studentdb[x].id != 0)
        {
            studentdb[x].display();
            break; 
        } 
    }

---

So as long as db!=0, the if will execute.

[edit] So the program probably uses the ID that was entered, but that loop uses the first student for all of the other data. [/edit]

Thanks for the help, everyone :)
Did I use objects okay? Were there any problems with my class?

Well, declaring an array of 1000 elements is overkill when you only access the first two elements. :) I see that your ID can be over 2, which is probably why you do that. But elements 3..999 are not initialized (since you don't have a constructor), so accessing them is probably useless anyway.

The best way to fix this would probably be to limit db (in main()) from 0 to 1, or whatever the maximum number is.

[edit] Also, since you have declared the member functions in the class inside the actual class, they are inline. (Well, it's like adding the inline keyword to a function: you suggest to the compiler that the function be inline.) This can be a bad thing for large member functions. The alternative is to declare the functions outside the class:

Code:

---

class c {
public:
    void func();
};

void c::func() {
    // ...
}

---

BTW, studant is spelled student. :) [/edit]

Quote:

---

Did I use objects okay? Were there any problems with my class?

---

Typically we would declare member variables as private as that makes it easier to change the implementation later without changing the public interface of the class.