Can someone please tell me what is wrong with this code?

I want to just take these numbers from the file one by one and assign them to different variables. I tried this just to see if I could get one to work and a get a crazy random number when it should just be 1.

Code:

---

#include <iostream>
#include <fstream>
using namespace std;
int main()
{        double x;
        ifstream input;
        input.open("chap10-Q1_input.txt");
        input>>x;
        cout<<x;
        return 0;
}

---

this is the file its connected to:

Code:

---

1  7  10  90 95
2  9  8  90 80
3  7  8  70 80
4  5  8  50 70
5  4  0  40 35

---

Please help

Quote:

---

Originally Posted by cloudstrife910

I want to just take these numbers from the file one by one and assign them to different variables. I tried this just to see if I could get one to work and a get a crazy random number when it should just be 1.

Code:

---

#include <iostream>
#include <fstream>
using namespace std;
int main()
{    double x;
    ifstream input;
        input.open("chap10-Q1_input.txt");
    input>>x;
    cout<<x;
        return 0;
}

---

Please help

---

Maybe you should check the return value of ifstream::open?

What do you mean? How would I do that? Sorry I'm pretty new to this.

Quote:

---

Originally Posted by Sebastiani

Maybe you should check the return value of ifstream::open?

---

ifstream::open doesn't return anything.
But the thing is that, if the open fails, then the fail bit is set. Thus you can do:

Code:

---

if (input.fail())
{
    // Code to handle failure here. Possibly exit application.
}

---

oh wow thank you, I did that. It wasn't opening correctly. I just assumed it was opening correctly cause the compiler didnt tell me. There was actually and underscore instead of a dash in the file name which messed it up.

Compilers don't say a thing about logic errors (except in some cases where it's smart enough to figure out you're shooting yourself in the foot, and then it's usually only when you have compiler warnings turned up pretty high) or failure to check return values and the like.

Quote:

---

Originally Posted by cloudstrife910

oh wow thank you, I did that. It wasn't opening correctly. I just assumed it was opening correctly cause the compiler didnt tell me. There was actually and underscore instead of a dash in the file name which messed it up.

---

Yes, you will encounter this a lot. Getting stuff to compile is relatively easy. Getting it to actually do what you want is very hard. In general, if a function has a chance of failure (which you can easily see from the documentation) you should have some code that you do in such a case. At the very least print an error message so you know what went wrong.

Or an assert.