Bug in Code

Code:

---

void main(int argc, char **argv[]) {
        int equals1 = 0;
        int equals2 = 0;
        int equals3 = 0;

        cout << "Enter a list of integers, that terminates with a letter (e.g. 1 2 3 4 k)" << endl;
        int value;
        while (cin >> value){
                switch (value) {
                        case 1: equals1++;
                        case 2: equals2++;
                        case 3: equals3++;
                }
        }
       
        char endOfInput;
        cin >> endOfInput;

        cout << equals1 << " inputs equals 1" << endl;
        cout << equals2 << " inputs equals 2" << endl;
        cout << equals3 << " inputs equals 3" << endl;

        int keypress; cin >> keypress;
}

---

This code doesnt work, when i debug it breaks down on the int equals1 = 0 line....anyone know why??

>> void main(int argc, char **argv[])
this is wrong

int main(int argc, char *argv[])
this isnt wrong

int main(int argc, char **argv)
this isnt really wrong either, the standard might specify which is correct... you might want to have a looksy and see.

edit: doh! copied and pasted void... ugh, i feel dirty now.

first try:
#include<iostream>
usind std::cout;
using std::cin;
using std::endl;

then:
int main(int argc, char **argv[])
{
....

return 0;
}

shoud run fine now

Borth wrong,

Code:

---

int main(int argc, char **argv[])  // not void and not **argv[], either **argv, or *argv[]
{
    ....

    return 0;
}

---

Edit: echo perspectives edit.

Not one of you has presented a correct version of a main definition in code...

Code:

---

int main( int argc, char* argv[] ) //or char** argv
{
    //...
    // return 0; is implicit
}

---

And just for reference in case someone reads this and doesn't know which of the four responses is correct (its PorkyChop):

http://www.research.att.com/~bs/bs_faq2.html#void-main

Quote:

---

Originally Posted by PorkyChop

Not one of you has presented a correct version of a main definition in code...

---

ack, ive been defeated by the copy/paste pitfall. see my edited post for feelings on the subject ;)

Just a note. Even though the 'return 0;' at the end of main (and only main) is implicit according to the standard (assuming you didn't say anything else), some compilers may scream at you about this... So just give them the 'return 0;' to make them happy.

Thanks for your help got it working, another point to note is that i missed the break statement at the end of each case so when a number 1 occured it also added to 2 and 3

To simplify your code a bit, you can use the simpler version of main (since you do not make use of the cmd line args). Here are the valid forms of main:

Code:

---

int main( )
int main(int argc, char** argv) // or char* argv[]

---