Segmentation error in vector?! How could this happen?

I used below codes to pass a value from vector to my cpp file. While i was doing that, i got segmentation fault in my main cpp? Is there anyway to pass the vector value to my main cpp? thx for the help

Code:

---

void Loadfile()
{
        //cout<<"this is used for loading file"<<endl;//check if the codes passing here
        string line;
    ifstream myfile;
    vector <string> myvector;
   
        myfile.open(DATAFILE);    // Open the datafile
        if (myfile.is_open())    //check If it worked
    {
                        while (getline(myfile,line,'\n'))//get whole line from DATAFILE
          {
                                                                                        //cout<<i++<<endl;//to test if the codes work correctly
            myvector.push_back(line);                //store them in vector
            }

---

Quote:

---

Originally Posted by bigbrain

I used below codes to pass a value from vector to my cpp file. While i was doing that, i got segmentation fault in my main cpp?

---

If I were to rewrite it with better indentation and following the rule of thumb that variables should be declared near first use:

Code:

---

void Loadfile()
{
    ifstream myfile(DATAFILE);
    if (myfile.is_open())
    {
        vector<string> myvector;
        string line;
        while (getline(myfile, line, '\n'))
        {
            myvector.push_back(line);
        }

---

Frankly, this code snippet looks okay. The problem probably lies in the code that you did not show, perhaps related to your next question...

Quote:

---

Originally Posted by bigbrain

Is there anyway to pass the vector value to my main cpp?

---

You could return a copy of the vector from Loadfile (potentially expensive option), or you could pass the vector in by reference.

A crash in a vector usually indicates you are attempting to access an index that does not exist or if you have pointers in the vector that those pointers are pointing to invalid memory and thus when you attempt to use the pointers you get a crash.