to Reverse the words in the string... help.. I just can't see the error...

I want to make a string to reverse the words but remain the words position the same.. (if input is "Hello world haha", the output should be "olleH dlrow ahah"), what should I do.. can I use the recursive method.. but how.. here is what I have done...

Code:

---

#include <stdio.h>
void revstr (char str[]);

main()
{
    char str[100];
    printf ("Enter the String :");
    gets (str);
    revstr (str);
    return 0;
}

void revstr (char str[])
{
    int i=0, j, k;
    char word[50], reverse[50];

        for (i=0; str[i]!='\0'; i++)
        {
            while (str[i]!=' ')
            {
                word[i]= str[i];
                word[i+1]='\0';
            }
        for (j=i, k=0; (j>=0) || (str[j]=' '); j--, k++)
        {
            reverse[k] = word[j];
            word[j] = '\0';
            reverse[k+1] = ' ';
                    reverse[k+2] = '\0';
        }
          puts (reverse);
        }
}

---

What I did is to iniciate word array to store words reverse array to reverse the letters, and put out the reverse array string by string.. it seem to be the stupidest way to do so...

Please use code tags when posting code. You can edit your original post using the "edit" button to add them.

The process can be as simple or complex as you'd like. For instance, a simpler but more difficult to understand method would be to use two pointers and walk down the string. When the end pointer finds a space or the end of the string, reverse from the start pointer to the end pointer and assign the end pointer to the start pointer. Lather, rinse, repeat.

Code:

---

#include <stdio.h>
#include <string.h>
#include <ctype.h>

static void revstr ( char *start, char *end )
{
  char hold;

  while ( start < end ) {
    hold = *start;
    *start = *end;
    *end = hold;

    start++;
    end--;
  }
}

int main ( void )
{
  char buf[] =  "Hello world haha";
  char *last = buf + sizeof buf;
  char *start = buf;
  char *end;

  for ( end = start; end != last; start = ++end ) {
    while ( *end != '\0' && !isspace ( *end ) )
      end++;

    revstr ( start, end - 1 );
  }

  printf ( "%s\n", buf );

  return 0;
}

---

-Prelude

Thanks for Prelude's reply really appricate a lot.. however, when I try to impliment into my programe with the functions, it have general protection exception error. :( and the programme halt. I don't understand what's went wrong. Could it be the problem of the string being pass down from the main program ?

Here is the whole programe.

Code:

---

#include <stdio.h>
#include <ctype.h>
#incldue <string.h>

int revstr (char str[]);
static void reverse ( char *start, char *end );

main()
{
    char str[100];
    printf ("Enter the String :");
    gets (str);
    revstr (str);
    return 0;
}

int revstr (char str[])
{
    char *last = str + sizeof str;
    char *start = str;
    char *end;

        for ( end = start; end != last; start = ++end ){
        while ( *end != '\0' && !isspace ( *end ) )
        end++;

        reverse ( start, end - 1 );
  }

  printf ( "%s\n", str );

  return 0;
}

static void reverse ( char *start, char *end )
{
  char hold;

  while ( start < end ) {
        hold = *start;
        *start = *end;
        *end = hold;

            start++;
            end--;
  }
}

---

Is there anything I can do with the programe. And what should I do to able to achieve the C programming skill like you. (I have seen the other reply you have pose... SUPERB!!!!) Any tips... :D

Try changing

Code:

---

gets(str);

---

to

Code:

---

fgets (str, sizeof str, stdin);

---

And

Code:

---

char *last = str + sizeof str;

---

to

Code:

---

char *last = str + strlen(str);

---

(And spell #include correctly.)

Quote:

---

fgets (str, sizeof str, stdin);

---

why fget is used instead of get?? Will that affected the rest of the function (which I have not pasted it there....)

Quote:

---

char *last = str + sizeof str;

---

and why I can't use sizeof.

Strange enough, when I run the previous programe Perlude produce it work without all these changes... I'm puzzled... :confused:

Sorry to keep bothering.. but just want to know the reason so that I can learn from there.. :p

>>why fget is used instead of get??
Dave gave you a link explaining this, look again here

>>and why I can't use sizeof
Well, you're trying to get the length of the string, and not how many bytes he takes, so strlen is the correct way to get the length of the string, sizeof operator returns the size of an object in bytes.

>why fget is used instead of get??
It helps to follow the links that try to anticipate your question.

>and why I can't use sizeof
Because in your function str is a pointer. In Prelude's code buf was an array. They have different sizes. You want the length of the string, not the size of a pointer to it.

Actually, I was a little lazy with that last one. I might modify the code like this.

Code:

---

#include <stdio.h>
#include <ctype.h>
#include <string.h>

static void reverse ( char *start, char *end )
{
    char hold;

    while ( start < end )
    {
        hold = *start;
        *start = *end;
        *end = hold;

        start++;
        end--;
    }
}

char *revstr (char str[])
{
    char *last = str + strlen(str) + 1;
    char *start = str;
    char *end;

    for ( end = start; end != last; start = ++end )
    {
        while ( *end != '\0' && !isspace ( *end ) )
            end++;

        reverse ( start, end - 1 );
    }

    return str;
}

int main(void)
{
    char str[100];
    printf ("Enter the String :");
    fflush(stdout);
    if(fgets (str, sizeof str, stdin) != NULL)
    {
        char *newline = strchr(str, '\n');
        if(newline != NULL)
        {
            *newline = '\0';
        }
        /*[edit] */else
        {
            while(getchar() != '\n');
        } /* [/edit] */
        printf ( "%s\n", revstr (str) );
    }
    return 0;
}

/* my output
Enter the String :here is the string to reverse
ereh si eht gnirts ot esrever
*/

---