Thread: Winsock HTML Page Source Dump...

Code:

    ofstream dparse ("d2jsp.txt");
    do {
       dRecv = recv(D2JSP, dbuf, 512, 0);
       dbuf[dRecv] = '\0';
       
       if (dRecv == SOCKET_ERROR) {
       cout<<"Failed to recieve data through D2JSP... " << WSAGetLastError() << endl;
       shutdown(D2JSP, 2); closesocket(D2JSP); WSACleanup();
       }
       else {
            if (!dparse.is_open()) { cout<<"Failed to open d2jsp.txt...\n"; break; }
            else if (dparse.is_open()) dparse << dbuf;
            }
               
       } while (dRecv > 0);
                       
    dparse.close();
    system("pause");
    
    shutdown(D2JSP, 2); closesocket(D2JSP); WSACleanup();
    return 0;
}

Code:

       dRecv = recv(D2JSP, dbuf, 512, 0);
       dbuf[dRecv] = '\0';

if recv fills the array, then you write one past the end of the array.

Code:

            if (!dparse.is_open()) { cout<<"Failed to open d2jsp.txt...\n"; break; }
            else if (dparse.is_open()) dparse << dbuf; /* unneeded */

huh? Anyways, is there anyone out there that can answer my question instead of trying to correct everything I write? Clearly, this isn't solving my problem.. Thanks...

You have bugs in your program. How do you know that those bugs aren't causing your problems? You'll have to fix these things anyway.

dbuf[dRecv] is an out of bounds access.

0-511 are valid, 512 is not.

also, when you copy a pointer, it doesn't copy the string.

Code:

dIP = inet_ntoa (*(in_addr*) dHost->h_addr);

i dont know what you mean by dIP.. it has that same line in the examples on the winsock reference. it works just fine and for dbuf its not giving me any runtime errors so it must not be appending it on 512 but i dont know i could dRecv-1

Originally Posted by blake_

i dont know what you mean by dIP..

that's your code. you should make it an array and strcpy it instead. Well, that's according to the docs at msdn. see post #8.

i could dRecv-1

good idea. make sure to change recv too, or you'll lose a byte.

ok so now what do i do so i stop getting incomplete lines?

Post the modified code, please.

Code:

int main()
{ 
    WSADATA WsaDat;
    SOCKET D2JSP;
    sockaddr_in D2;
    
    hostent* dHost;
    
    char *dIP, *request, dbuf[513];
    int dRecv;
    unsigned short dline = 0, cwrite = 0;
    request = "GET /index.php?showforum=168 HTTP/1.1\r\nHost: forums.d2jsp.org\r\n\r\n";
    
    if (WSAStartup(MAKEWORD(2, 0), &WsaDat) != 0) {
                               cout<<"WSAStartup failed to initalize...\n";
                               }
    D2JSP = socket(AF_INET, SOCK_STREAM, 0);
    if (D2JSP == INVALID_SOCKET) {
              cout<<"Failed to make D2JSP socket... " << WSAGetLastError() << endl;
              WSACleanup();
              }
    
    dHost = gethostbyname("forums.d2jsp.org");
    dIP = inet_ntoa (*(in_addr*) dHost->h_addr);
    cout<<"D2JSP IP: " << dIP << endl;
    
    D2.sin_family = AF_INET;
    D2.sin_addr.s_addr = inet_addr (dIP);
    D2.sin_port = htons (80);
    
    if (connect(D2JSP, (sockaddr*) &D2, sizeof(D2)) == INVALID_SOCKET) {
                       cout<<"Failed to connect to D2JSP socket... " << WSAGetLastError() << endl;
                       shutdown(D2JSP, 2); closesocket(D2JSP); WSACleanup();
                       }
    
    dSend(D2JSP, request);
    
    ofstream dparse ("d2jsp.txt");
    do {
       dRecv = recv(D2JSP, dbuf, 512, 0);
       if (dRecv == SOCKET_ERROR) {
          cout<<"Failed to recieve data through D2JSP... " << WSAGetLastError() << endl;
          break;
          }
          dbuf[dRecv+1] = '\0';
          if (!dparse.is_open()) { cout<<"Failed to open d2jsp.txt...\n"; break; }
          else dparse << dbuf;
       } while (dRecv > 0);
                       
    dparse.close();
    shutdown(D2JSP, 2); closesocket(D2JSP); WSACleanup();
    return 0;
}

Code:

dbuf[dRecv+1] = '\0';

No!

This does the same thing as you did before.

http://www.cprogramming.com/tutorial/c/lesson8.html

and put the returns/exits back.