Thread: simple shell (c), fgets problem

> when I use fgets to grab from the command line, rather than gets
You've got to strip off that newline before passing the parameters to your programs

> if you try ls / & ( then it complains)
Can you be more specific?

> its formatted, and color coded
Well it's colour coded, but I wouldn't say it was formatted
Formatted is where all the statements at the same scope level actually line up

well for ls for example:

ls /

(lists directory contents properly)

ls / &

ls: : No such file or directory
/:

Code:

int parse(char *buffer, char **v) {
int temp = 0;
        while (*buffer != '\0') // if not the end of buffer yet.
        {
                while (*buffer == ' ' || *buffer == '\t' || *buffer == '\n')
                *buffer++ = '\0';     // replace white spaces (includes tabs etc..)
                *v++ = buffer;          // save buffer place to v.

Once out of the while loop v is null terminated with *v = '\0'

wouldn't the above code take care of the final new line character?

> wouldn't the above code take care of the final new line character?
On the face of it, yes
But that doens't mean it actually works

Try printing each v[i] using this loop

Code:

for ( i = 0 ; v[i] != NULL ; i++ ) {
  printf( "param %d is '%s'\n", i, v[i] );
}

printing the string between two '' will allow you to see if there are any extra space/newlines which you didn't expect.


> Once out of the while loop v is null terminated with *v = '\0'
*v = NULL;
would be better

Thanks I didn't think of putting the value in ' ', which did help me spot something

Managed to fix it, so it works now.