Thread: A little problem with my game

ok so I am making a little game everything goes fine until I get to this:

Code:

printf("You are facing 1 goblins goblin 1 has %d hp and deal 10 dammage by hit\n",goblin1Health);
printf("(A)Attack Deals 25 Damage.\n");
printf("(H)Heal Heals 25 health.\n");
scanf("%c", battleCommands);

it says that the program has stopped working..

here is the complete source code:

Code:

#include <stdio.h>
char KnightName[100];
int goblin1Health = 50;
int playerHealth = 100;
char GoToBattle[10];
char battleCommands;


int main()
{
    putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');
    putchar('\n');
    putchar('[');
    putchar('\n');
    putchar('[');
    putchar('\n');                                                                                                                                
    putchar('[');
    putchar('\n');    printf("[   BattleKnight\n");
    putchar('[');
    putchar('\n');
    putchar('[');
    putchar('\n');
    putchar('[');
    putchar('\n');
    putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');putchar('_');
    putchar('\n');
    printf("What is your name brave warrior?\n");
    scanf("%s", &KnightName);
    
    menu();
  
  return 0;
}
void menu()
{
    printf("Welcome to BattleKnight %s\n", KnightName);
    printf("What do you want to do sir?\n");
    printf("Tip: Say the keywords of the options you are gived in here example: go to battle = battle\n", KnightName);
    printf("1- To Battle\n");
    scanf("%s", &GoToBattle);
        if(GoToBattle == 98, 97, 116, 116, 108, 101)
        {
            printf("You are facing 1 goblins goblin 1 has %d hp and deal 10 dammage by hit\n",goblin1Health);
            printf("(A)Attack Deals 25 Damage.\n");
            printf("(H)Heal Heals 25 health.\n");
            scanf("%c", battleCommands);
            if(battleCommands = 65)
            {
                printf("You attack goblin 1");
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                goblin1Health--;
                printf("You are facing 1 goblins goblin 1 has %d hp and deal 10 dammage by hit\n",goblin1Health);
            }
        }
    return 0;
}

note: I am using mingw compiler and I am new to programming also the language is C not c++

You if statement says

if(battleCommands = 65)

it should be

if(battleCommands == 65)

Code:

goblin1Health--;
goblin1Health--;
goblin1Health--;
...
goblin1Health--;

It would be easier to implement this as:

Code:

goblin1Health = goblin1Health - 25;

Or, alternatively:

Code:

goblin1Health -= 25;

You can define your functions before or after "main()" - if you define your functions after main ("function definition"), you have to declare them first before "main()" ("function declaration").

Code:

#include <stdio.h>

void function1(void);  // note semi-colon after "function declaration"

int main(void)
{
    function1();
    return 0;
}

void function1(void)   // note NO semi-colon after "function definition" line
{
    // code here
}

Also, you have your "menu()" function returning a value when the function is declared as not having a return type.

Code:

void menu()
{
    // your code

    return 0;  // <-- THIS DOES NOT BELONG if the return type of the function is "void"
}

This line also needs to be fixed:

Code:

if(GoToBattle == 98, 97, 116, 116, 108, 101)

You are trying to compare a user input string to integers. There are several ways to achieve a proper comparison correctly; one is with a string compare function.

There's probably more that needs fixing, but that's what I saw after a brief look-through.

Code:

char KnightName[50];
....
printf("What is your name brave warrior?\n");
scanf("%s", &KnightName);

You declare "KnightName" as an array of 50 chars therefore you don't need the & in front of the variable name (I assume you don't know about pointers yet, do you?)

Code:

printf("Tip: Say the keywords of the options you are gived in here example: go to battle = battle\n", KnightName);

You don't use the value of "KnightName" in the format string.

Code:

char GoToBattleCommand[7];
....
scanf("%s", &GoToBattleCommand);

Same as above.

Code:

char battleCommands;
....
scanf("%s", &battleCommands);
if (strcmp(attack,  battleCommands) == 0 )

You declare "battleCommands" as a char variable (an integer type), but later use it as a string.