I finished the beta version of Boardgames Online. I would appreciate any comments on my work.
you have a 200 kilobyte source file
Do you imply that it is too big? It is 5k lines of code... Except if you are on dial-up, which then I pity you (though I am in the second worst situation)
I think its a better habit to organize your code much better
though of course its hard to accept this fact since you yourself wrote it and understand it fully...try to abstract it more , detach anything having to do with chess from the main code
I can see why one file is convenient - that's one file to download for the source. But it would be better to distribute the source in a zip file, and have a file for, say, each class.
EDIT: And a project file/makefile.
But I really like the idea of describing where the players go:
Also I am wondering if you have implemented describing game rules yet - I didn't see any in the example. I am sure it will be interesting to see finished. Maybe a//a) UseTableCoord: each player is sitting around a square table (up to 4 players)
// This option is helpful for games that each player has a side, like chess and checkers or most card games
//b) TableHands: each card hand is placed on the bottom of the screen and has the appropriate color
// Used only when each player has a hand
Forgive me if you already had it done, I'm just going out on a whim here. The class names could probably use some work. And I don't even know if my idea is practical - heck, I don't even know C# - so take it for face value (no pun intended).Code://poker game WinningHand pair = new WinningHand(new PointsValue(20), new CardSet(5,CARD_N_A, CARD_N_A, CARD_ANY, CARD_ANY, CARD_ANY)); //CARD_N_A signifies a card of any face value (a count of 2 means at least two values must match) WinningHand fullhouse = new WinningHand(new PointsValue(100), new CardSet(5,CARD_N_A, CARD_N_A, CARD_N_A, CARD_N_B, CARD_N_B)); //and since fullhouse has the higher points value it takes precedence
Consider this post signed
Maybe I ll go with the many file approach. The makefile is good, but don't really know hot to make one in C#. I will get to it though.
Game rules are not really needed, in the sense that the game doesn't "force" any rules. For poker, you just show your cards and the winning player would get the chips from the table.
As for code organization, yeah. It needs better organization and name changes. I am just kind of lazy on that, cause I am more interested.
ChessBoard and ClassicDeck should probably be on another file.
But I will probably end up doing these changes after I finish the rest of ideas I have on this program so I can enable more boar games to be created...
So there's a dealer involved or at least some sort of player consensus as to who the winner is?For poker, you just show your cards and the winning player would get the chips from the table.
EDIT: Oh, I think I get it now - this isn't necessarily a video game in itself, just more of a natural online extension of real people getting around a table and playing cards.
Last edited by bernt; 05-19-2010 at 04:00 PM.
Consider this post signed
I really prefer my approach in the sense that I have seen some similar software that had just too many options in my opinion. Where in real life you play "freely" anyway. Of course, you can add some rules, the delagates make that really easy. Mostly to determine things like turn order, starting/end phases. More rules would require more complex changes