Thread: Simple program not working

  1. #1
    Registered User
    Join Date
    Jul 2003
    Posts
    97

    Simple program not working

    Im making a program. You type your name in the first textbox, hit the button that says Ok, and then if the first textbox has any text in it..it outputs "Your name sucks!!" to a other "non editable" text box below the button, or "Type your name fool!!" if the first textbox has no text in it.

    I cant get it to work, I will post the error after the codeing.

    Code:
    using System;
    using System.Drawing;
    using System.Collections;
    using System.ComponentModel;
    using System.Windows.Forms;
    using System.Data;
    
    namespace WindowsApplication3
    {
    	/// <summary>
    	/// Summary description for Form1.
    	/// </summary>
    	public class Form1 : System.Windows.Forms.Form
    	{
    		private System.Windows.Forms.Button button1;
    		private System.Windows.Forms.TextBox name1;
    		private System.Windows.Forms.TextBox output;
    		/// <summary>
    		/// Required designer variable.
    		/// </summary>
    		private System.ComponentModel.Container components = null;
    
    		public Form1()
    		{
    			//
    			// Required for Windows Form Designer support
    			//
    			InitializeComponent();
    
    			//
    			// TODO: Add any constructor code after InitializeComponent call
    			//
    		}
    
    		/// <summary>
    		/// Clean up any resources being used.
    		/// </summary>
    		protected override void Dispose( bool disposing )
    		{
    			if( disposing )
    			{
    				if (components != null) 
    				{
    					components.Dispose();
    				}
    			}
    			base.Dispose( disposing );
    		}
    
    		#region Windows Form Designer generated code
    		/// <summary>
    		/// Required method for Designer support - do not modify
    		/// the contents of this method with the code editor.
    		/// </summary>
    		private void InitializeComponent()
    		{
    			this.button1 = new System.Windows.Forms.Button();
    			this.name1 = new System.Windows.Forms.TextBox();
    			this.output = new System.Windows.Forms.TextBox();
    			this.SuspendLayout();
    			// 
    			// button1
    			// 
    			this.button1.Location = new System.Drawing.Point(112, 104);
    			this.button1.Name = "button1";
    			this.button1.TabIndex = 0;
    			this.button1.Text = "Ok";
    			this.button1.Click += new System.EventHandler(this.button1_Click);
    			// 
    			// name1
    			// 
    			this.name1.Location = new System.Drawing.Point(72, 32);
    			this.name1.Name = "name1";
    			this.name1.Size = new System.Drawing.Size(160, 20);
    			this.name1.TabIndex = 1;
    			this.name1.Text = "Replace with your NAME!";
    			// 
    			// output
    			// 
    			this.output.Location = new System.Drawing.Point(56, 200);
    			this.output.Name = "output";
    			this.output.ReadOnly = true;
    			this.output.Size = new System.Drawing.Size(192, 20);
    			this.output.TabIndex = 2;
    			this.output.Text = "";
    			// 
    			// Form1
    			// 
    			this.AutoScaleBaseSize = new System.Drawing.Size(5, 13);
    			this.ClientSize = new System.Drawing.Size(292, 266);
    			this.Controls.Add(this.output);
    			this.Controls.Add(this.name1);
    			this.Controls.Add(this.button1);
    			this.Name = "Form1";
    			this.Text = "Form1";
    			this.ResumeLayout(false);
    
    		}
    		#endregion
    
    		/// <summary>
    		/// The main entry point for the application.
    		/// </summary>
    		[STAThread]
    		static void Main() 
    		{
    			Application.Run(new Form1());
    		}
    
    		private void button1_Click(object sender, System.EventArgs e)
    		{
    			if(name1.Text > 1)
    			{
    				output.Text = "Your name sucks!"; 
    			} 
    			else 
    			{
    				output.Text = "Enter a name you fool.";
    			}					 
    
    		}
    
    
    	}
    }
    Heres what the compiler gives as the error:

    Code:
    C:\Documents and Settings\Ryan Sands\My Documents\Visual Studio Projects\WindowsApplication3\Form1.cs(112): Operator '>' cannot be applied to operands of type 'string' and 'int'

  2. #2
    Banned nickname_changed's Avatar
    Join Date
    Feb 2003
    Location
    Australia
    Posts
    986
    Quote Originally Posted by oobootsy1
    if(name1.Text > 1)
    {
    What's happening here is you are comparing the text (a bunch of letters) against a number (the number 1). That doesn't make sense. What you actually want to do is compare the length of the text with 1, like this:

    if (name1.Text.Length > 1)

    Hope that helps.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Simple Blackjack Program
    By saber1357 in forum C Programming
    Replies: 1
    Last Post: 03-28-2009, 03:19 PM
  2. Replies: 10
    Last Post: 09-07-2008, 11:38 PM
  3. Replies: 4
    Last Post: 02-21-2008, 10:39 AM
  4. simple frontend program problem
    By gandalf_bar in forum Linux Programming
    Replies: 16
    Last Post: 04-22-2004, 06:33 AM
  5. unable to get simple program working
    By toom in forum Linux Programming
    Replies: 1
    Last Post: 10-11-2003, 05:05 AM