Thread: Looking for C# best practices/coding guidelines

Originally Posted by nvoigt

As a note for Sleep: Don't. Simple as that. Don't. All threading features in C# have a way to call you back when they are finished. Sleeping is an error, plain and simple. Even sleeping in a loop waiting for a condition is bad programming.

You might want to look into static code analasys in Visual Studio (former FxCop) and the StyleCop Plugin for R#.

Can you explain why something like this is bad?

Code:

// psudo-code
proc = Process( "some_test.exe" );

while ( proc.IsRunning() )
{
    Sleep( 100 );
}

// Collect test result...

Oh, and maybe I should clarify what kind of code my team writes. We do QA Automation, so we write automated tests for production software. Maybe that would have an effect on some of the coding guidelines I should be recommending?