Thread: Numbers to Text revisited

I appologize for screwing up the initial thread Bubba. No excuses. I am reposting my changed code and hope everyone is still willing to help a newbie.

I have my code working but for the life of me I can't get is to write the results to the console. I'm sure its something simple. I just cant seem to get Console.Writeline to show it too me.

Main

Code:

 class Program
    {
        static void Main(string[] args)
        {
            NumberString Demo = new NumberString();  //creating a new NumberString object
            Demo.Number = 1234;
            string NumberText = Demo.Text;
            Demo.Text = "one million four hundred seventy five thousand fifteen";
            int n = Demo.Number;

            NumberString.numbervalue(Demo.Number);  //calling my method "numbervalue"

            Console.WriteLine();
            Console.Read();
        }

My new class

Code:

class NumberString
    {
        public int Number //"Number" is a property of class "NumberString"
        { get; set; }

        public string Text  //"Text" is a property of class "NumberString"
        { get; set; }


        private static string[] undertwenty = new string[]  //Numbers less than twenty
            {"zero", "one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten", "eleven",
            "twelve", "thirteen", "fourteen", "fifteen", "sixten", "seventeen", "eighteen", "nineteen"};

        private static string[] tens = new string[] //two digit numbers twenty and over
            { "", "", "twenty", "thirty", "forty", "fifty", "sixty", "seventy", "eighty", "ninty" };

        private static string[] bigs = new string[]  //for numbers 3 digits and over
            { "hundred", "thousand", "million" };

        public static string numbervalue(int Number)
        {

            if (Number == 0)
                return undertwenty[0];

            int[] groupdigits = new int[4];

            int positive = Math.Abs(Number);

            for (int i = 0; i < 4; i++)  //seperate into groups
            {
                groupdigits[i] = positive % 1000;
                positive /= 1000;
            }

            string[] grouptext = new string[4];
            for (int i = 0; i < 4; i++)
                grouptext[i] = digitstowords(groupdigits[i]);

            string combined = grouptext[0];
            bool add_and;

            add_and = (groupdigits[0] > 0) && (groupdigits[0] < 100);

            for (int i = 1; i < 4; i++)
            {
                if (groupdigits[i] != 0)
                {
                    string prefix = grouptext[i] + " " + bigs[i];
                    if (combined.Length != 0)
                        prefix += add_and ? " and " : "' ";

                    add_and = false;

                    combined = prefix + combined;
                }
            }

            if (Number < 0)
                combined = "Negative " + combined;

            return combined;
        }

        private static string digitstowords(int three_digits)
        {
            string grouptext = "";
            int hundreds = three_digits / 100;
            int Tens = three_digits % 100;

            if (hundreds != 0)
            {
                grouptext += undertwenty[hundreds] + " Hundred";
                if (Tens != 0)
                    grouptext += " and ";
            }

            int ten = Tens / 10;
            int ones = Tens % 10;

            if (ten >= 2)
            {
                grouptext += tens[ten];
                if (ones != 0)
                    grouptext += " " + undertwenty[ones];
            }
            else if (Tens != 0)
                grouptext += undertwenty[Tens];

            return grouptext;
        }

    }
}

Your numberValue method takes care to return a string object. Your main function should take as much care to not promptly throw that string object straight into the trash.

Also,

Code:

Console.WriteLine(Hey did you want to print something? Where did it go?)

Thanks tabstop. Watching the debugger I have my converted text in my string "combined"

"Your main function should take as much care to not promptly throw that string object straight into the trash."

How do I keep my returned string in main so I can write it to the console?

Thanks for your help, obviously new at this but trying to learn!

You might consider, you know, assigning it to a variable?

Let me see if I am understanding this correctly.
In option 2 I am telling it to write to the console the return value of my method? Then option 1 is just setting the return value to a string variable then have it write that variable to the console?

Option 2 looks cleaner but setting it to a variable might be useful if you wanted to manipulate it elsewhere?

Thank you very much for taking time to help me learn this!

Very helpful! Thank you!

If you were doing this professionally and wanted to go the other way and convert text to a number should it be written in its own class or would you write them both in the same class?

I am assuming that will take about another 100 lines of code to do the opposite.

Thanks!!!

I'm working on going the other way and converting words to numerals. I have it splitting the words up, setting up a List collection, and going into a switch. Its setting each element of the list to the correct numeral. Now I am struggling with the logic/math to put the numerals back together in the correct format. I think I need to start with the "million" then "thousand" ect.

Can anyone point me the right direction?

Code:

  public static int digitvalue(string Text)
        {
            string TextToLow = Text.ToLower();                  //set string to lower case
            string[] array = TextToLow.Split(',', ' ');         //take out commas and spaces and put into an array
            List<int> list = new List<int>();                  //set up a list collection of ints

            for (int i = 0; i < array.Length; i++)            //loop through my array 
            {
                string number;
                number = array[i];

                switch (number)
                {
                    case "zero":                  //under twentys 0-19
                        list.Add(0);
                        break;
                    case "one":
                        list.Add(1);
                        break;
                    case "two":
                        list.Add(2);
                        break;
                    case "three":
                        list.Add(3);
                        break;
                    case "four":
                        list.Add(4);
                        break;
                    case "five":
                        list.Add(5);
                        break;
                    case "six":
                        list.Add(6); ;
                        break;
                    case "seven":
                        list.Add(7);
                        break;
                    case "eight":
                        list.Add(8);
                        break;
                    case "nine":
                        list.Add(9);
                        break;
                    case "ten":
                        list.Add(10);
                        break;
                    case "eleven":
                        list.Add(11);
                        break;
                    case "twelve":
                        list.Add(12);
                        break;
                    case "thirteen":
                        list.Add(13);
                        break;
                    case "fourteen":
                        list.Add(14);
                        break;
                    case "fifteen":
                        list.Add(15);
                        break;
                    case "sixteen":
                        list.Add(16);
                        break;
                    case "seventeen":
                        list.Add(17);
                        break;
                    case "eighteen":
                        list.Add(18);
                        break;
                    case "nineteen":
                        list.Add(19);
                        break;
                    case "twenty":              //twenty to ninty the "ty's"
                        list.Add(20);
                        break;
                    case "thirty":
                        list.Add(30);
                        break;
                    case "forty":
                        list.Add(40);
                        break;
                    case "fifty":
                        list.Add(50);
                        break;
                    case "sixty":
                        list.Add(60);
                        break;
                    case "seventy":
                        list.Add(70);
                        break;
                    case "eighty":
                        list.Add(80);
                        break;
                    case "ninty":
                        list.Add(90);
                        break;
                    case "hundred":                   //bigs 100's, 1000's, 1000000's 
                        list.Add(100);
                        break;
                    case "thousand":
                        list.Add(1000);
                        break;
                    case "million":
                        list.Add(1000000);
                        break;
                    default:
                        break;
                }

                
            }
            Console.WriteLine(list.Count);  //list.count gives # of items in "list"

            return list[0];
        }

    }
}

Yes I understand adding up the items in the list. Its the logic part that has me stumped. Say you have the text: "two million four hundred thirty thousand one hundred twenty three"

If I just add up the list you get: 1001260

Somehow I've got to grab the million, mutiply it by two and set it aside.

Then grab the thousand, mutiply it by four hundred thirty and set it aside.

Grab the hundred multiply it by one then add the twenty and the three.

Lastly add those three groups together to get 2430123.

I think this is the way to do it but maybe I'm making it over complicated

Thanks for the help. I got the logic working as follows:

Code:

foreach (int a in list)
            {
                int temp;
                temp = a;

                if (a <= 90)
                    Current += temp;

                if (a == 100)
                    Current *= temp;

                if (a == 1000 || a == 1000000 || a == 1000000000)
                {
                    Current *= temp;
                    Result += Current;
                    Current = 0;
                }
            }
            Result += Current;

            return Result;