Thread: Updating A Database From A Web Service

Originally Posted by enkwiringmindz

I have this code in a web service, but when I try to update the database using the second method (setContacts), it does not update at all, although I do not get an error message.

Code:

[WebMethod] 
public DataSet getContacts() 
{ 
   using (SqlConnection con = new SqlConnection(connString)) 
   {  
      DataSet ds = new DataSet("Contacts"); 
      SqlCommandBuilder cb = new SqlCommandBuilder(da); 
      da = new SqlDataAdapter("SELECT * FROM Contacts", con); 
      da.Fill(ds); 
     return ds; 
   }; 
} 

[WebMethod] 
public void setContacts(DataSet data) 
{ 
   using (SqlConnection con = new SqlConnection(connString)) 
   { 
      DataSet ds = new DataSet("Contacts"); 
      SqlCommandBuilder cb = new SqlCommandBuilder(da); 
     da = new SqlDataAdapter("SELECT * FROM Contacts", con); 
    da.Update(data, "Contacts"); 
   }; 
}

First of all, your SqlCommandBuilder is not going to do anything because there is no instance of da when this line runs. So those two lines need to be reversed. Check here (SqlCommandBuilder Class (System.Data.SqlClient)) to set up the command builder to properly create commands for you.

I meant to ask also. What are you planning on doing with the DataSet ds? Right now, it has no tables and is not used. So i'm wondering if you are getting confused with "Contacts" and what should be updated. The link I gave you should help explain some things.