Thread: What am I doing wrong?

Here is just the while loop. The object is to add the integers in the file until the sum < = 1000.

Code:

sum = 0;
under = true;

	while (inFile && under)

	{	
		if (sum > 1000)
			under = false;
		
		else 
			sum = sum + num;
	}
	
	outFile << "The sum of integers which does not exceed 1000 is " << sum << "." <<endl;
			

	inFile.close();
	inFile.clear();

You never actually read anything from inFile.

Originally Posted by brewbuck

You never actually read anything from inFile.

Code:

inFile.open ("K:\\DATFILE1.TXT");
	
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	
sum = 0;
under = true;
inFile >> num;

	while (inFile && under)

	{	
		if (sum > 1000)
			under = false;
		
		else 
			sum = sum + num;
			
	}
	
	outFile << "The sum of integers which does not exceed 1000 is " << sum << "." <<endl;
			

	inFile.close();
	inFile.clear();


return 0;
}

My result is still over 1000.

Originally Posted by dwks

You're adding the same number to sum over and over again. You probably want something like this:

Code:

while(cin >> num) {
    sum += num;
    if(sum > 1000) {
        // ...
    }
}

Actually, I'm not adding the same number to sum over and over. It pulls in the next number from the file. I know that the answer is going to be something I could kick myself for as that has been the case with the prior 4 parts of the program. I just can't figure it out.

Originally Posted by dwks

Umm . . . are you sure? Why don't you try code similar to what I used and see what happens?

I'm absolutely sure. This is part 7 of the program with me using the infile for all of the solutions.

Irrespective of the fact that based on the code you've provided you are *NOT* reading a new number from the file on each loop iteration...

Code:

while (inFile >> num)
{
   // If sum here is 999, and num is 2,
   // what's going to happen to sum?
   if (sum > 1000)
      under = false;
   else 
      sum = sum + num;
}

I am soooo confused... Ok, Im going to post the whole program..... maybe this will clear things up..

Code:

#include<iostream>
#include<fstream>
#include<iomanip>
#include<cmath>

using namespace std;

int main()
{

//Declare and open files
	ifstream inFile;
	ofstream outFile;

	float num;
	float average;
	float sum = 0;
	int count = 0;
	float highest = 0;
	float lowest = 1000;
	float x;
	float closest = 200;
	bool under;
	char inChar;
	
	
	outFile.open ("K:\\ANSWERS.TXT");
	

//*****************************************************************************************
	inFile.open ("K:\\DATFILE1.TXT");
	
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	outFile<<"The file contains the following data:  "<<endl;
	inFile >> num;
	while (inFile)
	{
		outFile << num <<" ";
		inFile >> num;
	}

	inFile.close();
	inFile.clear();

//******************************************************************************************

	inFile.open ("K:\\DATFILE1.TXT");
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	
	inFile >> num;	
	
		while (inFile)
		{
			sum = sum + num;
			count++;
			inFile >> num;
		}	

	average = sum / count;

	outFile << fixed << setprecision(3)
			<<"The average of all the integers is "<< average << "."<<endl;
	
	inFile.close();
	inFile.clear();
//******************************************************************************************

	inFile.open ("K:\\DATFILE1.TXT");
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	count = 0;
	average = 0;
	sum = 0;
	
	while ( count < 12)     
    {
		inFile >> num;
		sum = sum + num;    
		count++;
	   
	}
	average = sum / count;

	outFile << fixed << setprecision(3)
			<<"The average of the first 12 integers is "<< average << "."<<endl;

	
	inFile.close();
	inFile.clear();
//******************************************************************************************

	inFile.open ("K:\\DATFILE1.TXT");
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	count = 0;
	sum = 0;

	inFile >> num;
	

	while (inFile)
	{
		count++;
		if (count ==1)
			count = 1;

		else if (count == 2)
			count = 2;	

		else if (count == 3)
			sum = sum + num;

		else if (count > 3)
			count = 1;
		
		inFile >> num;	
	}
		
	outFile << fixed << setprecision(0)
			<<"The sum of every third number is " << sum << "."<< endl;
	
	inFile.close();
	inFile.clear();

//******************************************************************************************

	inFile.open ("K:\\DATFILE1.TXT");
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	
	inFile >> num;
	
		while (inFile)
		{
			inFile >> num;

			if (num < lowest)
					lowest = num;
			
			if (num > highest)
				highest = num;

		}

	outFile << "The range of numbers is from "<< lowest << " to " << highest << "." 
			<<endl;	

	inFile.close();
	inFile.clear();

//*****************************************************************************************
	inFile.open ("K:\\DATFILE1.TXT");
	
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	
	inFile >> num;
	
		while (inFile)
		{
			inFile >> num;
			x = abs(num - 200);

			if (x < closest)
					closest = num;			
		}

	outFile << "The closest number in the file to 200 is " << closest << "."<< endl;

	inFile.close();
	inFile.clear();
//*****************************************************************************************

//*****************************************************************************************
inFile.open ("K:\\DATFILE1.TXT");
	
	if ( !inFile )
	{
		cout<< "**Can't open input file**" <<endl;
		return 1;
	}
	
sum = 0;
under = true;
inFile >> num;

	while (inFile && under)
	{	
		if (sum > 1000)
			under = false;
		
		else 
			sum = sum + num;
			
	}
	
	outFile << "The sum of integers which does not exceed 1000 is " << sum << "." <<endl;
			

	inFile.close();
	inFile.clear();


return 0;

and yes I see that I forgot to read from file...

I think that I need to take a break from this stuff at night... ughhhhhh