Major help with my code...

**HelpLol** · 02-02-2008

Hi im new here, and I just need a bit of help.
When I compile this and get to the part where i'm meant to type in a word, (Page) It just skips to the end and says: "Press any key to continue".

Any help?

Code:

#include <iostream>
using namespace std;
int main()
{
    float STR;
    float DEX;
    float WA;
    int MIN;
    int MAX;
    float COMBO;
    float PANIC;
    float SkillMastery;
    float POWER;
    float WDEF;
    float ORBS;
    float SLASHB;
    float RAGE;
    float JOB;
    float JOBB;
    float WEAPON;
    float Page;
    float Fighter;
    float Spearman;
    float NormalWarrior;
    float TwoHandedMace;
    float OneHandedMace;
    float OneHandedSword;
    float TwoHandedSword;
    float age;
    cout<<"Welcome to John's axe warrior damage calculator v.0.1";
    cout<<"---------------------------------------Note: 'a' for max or min means 1 damage or 'miss'---------------------------------------------------------------------------------------------------";
    
    cout<<"Enter STR:";
    cin>>STR;
    cout<<"Enter DEX:";
    cin>>DEX;
    cout<<"Enter Weapon Attack:";
    cin>>WA;
    cout<<"Enter Skill Mastery:";
    cin>>SkillMastery;
    cout<<"Power Strike? (1.14 - 2.60):";
    cin>>POWER;
    cout<<"Slash blast? (.57 - 1.3):";
    cin>>SLASHB;
    cout<<"Monsters Defence?";
    cin>>WDEF;
    cout<<"Type of warrior? (Normal Warrior, Fighter, Spearman, Page)";
    cin>>JOB;
    if ( JOB = Page ) 
    {                 
                      cout<<"Type of weapon? (2hSword, 2hMace, 1hSword, 1hMace...)";
                      cin>>WEAPON;
                      if ( WEAPON = TwoHandedSword ) 
                    {        
                             MIN = ((((STR*0.9*SkillMastery*3.4) + DEX)/100 * WA)) -WDEF;
                             MAX = ((((STR*4.6) + DEX)/100 * WA)) -WDEF;
    
                             cout<<"Minimum damage (normal slash):";
                             cout<<MIN<<endl;
                             cout<<"Maximum damage (normal slash):";
                             cout<<MAX<<endl;
    
                             system ("PAUSE");
                             int MINP;
                             int MAXP;
                             MINP = ((MIN+WDEF)*POWER)-WDEF;
                             MAXP = ((MAX+WDEF)*POWER)-WDEF;
                             cout<<"Minimum damage with power strike:";
                             cout<<MINP<<endl;
                             cout<<"Maximum damage with power strike:";
                             cout<<MAXP<<endl;   
                             system ("PAUSE");
                             int MINSB;
                             int MAXSB;
                             MINSB = ((MIN+WDEF)*SLASHB)-WDEF;
                             MAXSB = ((MAX+WDEF)*SLASHB)-WDEF;    
                             cout<<"Minimum damage with slash blast:";
                             cout<<MINSB<<endl;
                             cout<<"Maximum damage with slash blast:";
                             cout<<MAXSB<<endl;
    
                             system ("PAUSE");
                             return 0;   
                     }
                             else if ( WEAPON = TwoHandedMace ) 
                     {            
                             MIN = ((((STR*0.9*SkillMastery*3.2) + DEX)/100 * WA)) -WDEF;
                             MAX = ((((STR*4.8) + DEX)/100 * WA)) -WDEF;
    
                             cout<<"Minimum damage (normal slash):";
                             cout<<MIN<<endl;
                             cout<<"Maximum damage (normal slash):";
                             cout<<MAX<<endl;
    
                             system ("PAUSE");
                             int MINP;
                             int MAXP;
                             MINP = ((MIN+WDEF)*POWER)-WDEF;
                             MAXP = ((MAX+WDEF)*POWER)-WDEF;
                             cout<<"Minimum damage with power strike:";
                             cout<<MINP<<endl;
                             cout<<"Maximum damage with power strike:";
                             cout<<MAXP<<endl;   
                             system ("PAUSE");
                             int MINSB;
                             int MAXSB;
                             MINSB = ((MIN+WDEF)*SLASHB)-WDEF;
                             MAXSB = ((MAX+WDEF)*SLASHB)-WDEF;    
                             cout<<"Minimum damage with slash blast:";
                             cout<<MINSB<<endl;
                             cout<<"Maximum damage with slash blast:";
                             cout<<MAXSB<<endl;
    
                             system ("PAUSE");
                             return 0;           
                    }
                             else if ( WEAPON = OneHandedSword )
                    {
                             MIN = ((((STR*0.9*SkillMastery*4) + DEX)/100 * WA)) -WDEF;
                             MAX = ((((STR*4) + DEX)/100 * WA)) -WDEF;
    
                             cout<<"Minimum damage (normal slash):";
                             cout<<MIN<<endl;
                             cout<<"Maximum damage (normal slash):";
                             cout<<MAX<<endl;
    
                             system ("PAUSE");
                             int MINP;
                             int MAXP;
                             MINP = ((MIN+WDEF)*POWER)-WDEF;
                             MAXP = ((MAX+WDEF)*POWER)-WDEF;
                             cout<<"Minimum damage with power strike:";
                             cout<<MINP<<endl;
                             cout<<"Maximum damage with power strike:";
                             cout<<MAXP<<endl;   
                             system ("PAUSE");
                             int MINSB;
                             int MAXSB;
                             MINSB = ((MIN+WDEF)*SLASHB)-WDEF;
                             MAXSB = ((MAX+WDEF)*SLASHB)-WDEF;    
                             cout<<"Minimum damage with slash blast:";
                             cout<<MINSB<<endl;
                             cout<<"Maximum damage with slash blast:";
                             cout<<MAXSB<<endl;
    
                             system ("PAUSE");
                             return 0;     
                   }
                             else if ( WEAPON = OneHandedMace )
                   {
                             MIN = ((((STR*0.9*SkillMastery*3.6) + DEX)/100 * WA)) -WDEF;
                             MAX = ((((STR*4.4) + DEX)/100 * WA)) -WDEF;
    
                             cout<<"Minimum damage (normal slash):";
                             cout<<MIN<<endl;
                             cout<<"Maximum damage (normal slash):";
                             cout<<MAX<<endl;
    
                             system ("PAUSE");
                             int MINP;
                             int MAXP;
                             MINP = ((MIN+WDEF)*POWER)-WDEF;
                             MAXP = ((MAX+WDEF)*POWER)-WDEF;
                             cout<<"Minimum damage with power strike:";
                             cout<<MINP<<endl;
                             cout<<"Maximum damage with power strike:";
                             cout<<MAXP<<endl;   
                             system ("PAUSE");
                             int MINSB;
                             int MAXSB;
                             MINSB = ((MIN+WDEF)*SLASHB)-WDEF;
                             MAXSB = ((MAX+WDEF)*SLASHB)-WDEF;    
                             cout<<"Minimum damage with slash blast:";
                             cout<<MINSB<<endl;
                             cout<<"Maximum damage with slash blast:";
                             cout<<MAXSB<<endl;
    
                             system ("PAUSE");
                             return 0;     
                             }
                             }
                             }

**Dino** · 02-02-2008

Code:

 if ( JOB == Page )

edit - you've never initialized Page. Fix your indentation too.

**Elysia** · 02-02-2008

You dearly need to learn to indent. That code is a mess, sorry.
http://cpwiki.sf.net/User:Elysia/Indentation
Should put you on the right track.
Also up warnings to max and pay heed to them. Assigning within an if should be warned by some compilers.

**Yarin** · 02-02-2008

Use spaces man! Your code is so squished together it's unpleasent to read.

>> Assigning within an if should be warned by some compilers.
Hmm, I don't know about anyone else, but I'm glad my compiler doesn't.

**Elysia** · 02-02-2008

You be unhappy it doesn't.
If (x = y)
Is a faulty if and is caught by some compilers.
if (x == y)
is correct and
int x;
if ( (x = y()) == false )
Should also work.

**Yarin** · 02-02-2008

That's true... I have accidently left out one of the = and ended up with an infinit loop.

But it is nice for code like this:

Code:

if(!(handle = CreateHandle())) return FALSE;

EDIT: right, you already said that. You'r right, I be unhappy.

**HelpLol** · 02-02-2008

I added all the extra '=', and now it just closes after I type in 'Page' and press enter. What? Lol.

**matsp** · 02-02-2008

Right, WEAPON is a float, which you read after asking for something that looks like a string, and then you compare the value [assuming you have changed your single equal to a double equal] with a uninitialized float value. That means that there's no telling when/if this is true or not...

Code:

    float WEAPON;
...
                      cout<<"Type of weapon? (2hSword, 2hMace, 1hSword, 1hMace...)";
                      cin>>WEAPON;
                      if ( WEAPON = TwoHandedSword ) 
...

You probably want to read a string, and compare it with some string constants.

Aside from the points commented on above, I would say that you should consider using a function for your actual calculation, rather than copy'n'paste essentially the same piece of code 4 times over - the only bits that vary are the multipliers in the first two calculations - those should be parameters to the function.

--
Mats

Thread: Major help with my code...

Thread Tools

Search Thread

Display

Major help with my code...

Similar Threads

Extended ASCII Characters in an RTF Control

Enforcing Machine Code Restrictions?

Obfuscated Code Contest

Interface Question

Who will map the scan code (inserted by VKD_Force_keys) to virtual key code?