Thread: Problems with an If loop..

I'm more concerned with repetition of the code and it outputting whether or not it's right. I am able to make it repeat, but it won't output the outcome anymore.

Code:

 {
    for (int j = 0; j < 10; ++j)
		random_integer1 = lowest+int(range*rand()/(RAND_MAX + 1.0));
        random_integer2 = lowest+int(range*rand()/(RAND_MAX + 1.0));
       
       cout << "If I add  " << random_integer1 << " and  " << random_integer2 <<
         " then what do I have? " << endl;
        cin >> answer;

		realanswer=random_integer1+random_integer2;
	}

I must be missing something within these statements?

I'm pretty ignorant.

Well You guys are telling me to get rid of all my spaces/tabs, and I really don't understand how thats going to solve my problem. It's probably more of a style thing so that it's easier for you to look at. I don't know, i'm just messy. I really haven't taken any classes to speak of so I'm at a disadvantage. Still If you tell me how you think I should structure my program based on tabs/spaces I will do so. I just need a layman's explanation. I'm not pro.

Seems a little irrelevant to me but then again i'm used to looking at my own code and I see differently than you might.

Code:

#include <iostream>
#include <ctime> 
#include <cstdlib>

using namespace std;

int main()
{ 
  srand((unsigned)time(0));
  int answer,i;
  int realanswer;
  int random_integer1;
  int random_integer2;
  int lowest=0, highest=49;
  int range=(highest-lowest)+1;
  char ch;


  for (int j = 0; j < 10; ++j)
  {
  random_integer1 = lowest+int(range*rand()/(RAND_MAX + 1.0));
  random_integer2 = lowest+int(range*rand()/(RAND_MAX + 1.0));
  cout << "If I add  " << random_integer1 << " and  " << random_integer2 <<
  " then what do I have? " << endl;
  cin >> answer;

  realanswer=random_integer1+random_integer2;
  }
  for (int j = 0; j < 10; ++j)
  {
   for(i=0;i<2;i++)
	{
   if (answer == realanswer)
		                 {
   cout<<"You are Right"<<"\n";
   break;
   }
    else
    {
	if(i==1)
	{
	cout<<"You are wrong. The right answer is "<<realanswer<<"\n";
			}
	else
	{
	cout<<"Oops! You are wrong. Try again...\n";
	cin>>answer;
}
}
}
}
}

does that mean I only hit it once, because everything just lines up and the eye won't see the difference in the statements...?

Okay so now I did spaces. Whatya think?

Code:

 #include <iostream>
#include <ctime>
#include <cstdlib>
 using namespace std;
 int main()
 {
 srand((unsigned)time(0));
 int answer,i;
 int realanswer;
 int random_integer1;
 int random_integer2;
 int lowest=0, highest=49;
 int range=(highest-lowest)+1;
 char ch;

    for (int j = 0; j < 10; ++j)
    {
     random_integer1 = lowest+int(range*rand()/(RAND_MAX + 1.0));
     random_integer2 = lowest+int(range*rand()/(RAND_MAX + 1.0));
     cout << "If I add  " << random_integer1 << " and  " << random_integer2 <<
     " then what do I have? " << endl;
     cin >> answer;

     realanswer=random_integer1+random_integer2;
     }
     for (int j = 0; j < 10; ++j)
     {
       for(i=0;i<2;i++)
        {
        if (answer == realanswer)
		                 {
         cout<<"You are Right"<<"\n";
         break;
         }
          else
          {
           if(i==1)
            {
	         cout<<"You are wrong. The right answer is "<<realanswer<<"\n";
			}
	         else
	          {
	           cout<<"Oops! You are wrong. Try again...\n";
               cin>>answer;
}
}
}
}
}

You want me to indent with 4 or 8?

Who are you to judge?

I thought his code was mostly spaces with a few tabs messing it up. Now that I look back it seems the other way round (duh). I just meant to change them to the same thing. It's the _mixing_ I can't stand!

To Sedvan: to say people's advice is "irrelavant" is pathetic. Programming is about communication, with the machine _and_ with people. Coding style is common courtesy, as well as a no-brainer for people with any experience. If you want people's advice (read "time"), then you have to meet them halfway. Personally, I can't believe how gracious the explicators here are sometimes. But for their example I would say "scrap it and take up knitting".

(Note: He's posting this on multiple sites and seemlingly just accumulating code as he goes.)