Thread: ofstream

@Elisya
I was thinking about to use something like:
transform (ch.begin(), ch.end(), ch.begin(), toupper);
but what you're saying sounds easier, thanks.

@Cpjust
Yeah i was a bit confused 'bout it , thanks for pointing it out , i'll fix it.

I'm done with it and im glad.
Im gonna use it to write subtitles and want to offer it to those who are writing them also.
It seems to work with other extentions than .txt like .srt...
Thanks again for the help for everybody.

Code:

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
  cout << "Enter file name : ";
  char FileName[99];
  cin  >> FileName;
  ifstream TheFile(FileName);
  ofstream TheCopy;
  TheCopy.open ("YourUppercasedCopy.srt",ios::app);
  string ch;
  
  while (getline(TheFile,ch))
  {      
          ch[0] = (char)toupper(ch[0]);
          TheCopy << ch << endl;
          
  }
  TheCopy.close();
  TheFile.close();
   
}

Using >> to a char buffer is not typically safe (try std::string instead).
And you're only upping the first letter of each row, in case you wanted to up every letter of every word.

I tried to do it with std::string first but it didnt compile that way i dont know why.

Code:

cout << "Enter file name : ";
  string FileName;
  cin  >> FileName;
  ifstream TheFile(FileName);  <-- compile error here

And upping every word was just a step in between because i didnt know how to up only the first word.

No, of course not... The C++ I/O really could have been done better.
You can use cin.get or cin.read to fetch X amount of characters from the stream. That way you won't have a buffer overrun if the filename is too long.

Needs a char array, and also specify the size of the array.

References

Code:

std::string fileName;
std::getline(std::cin, fileName);
std::ifstream fin(fileName.c_str());

Thanks Cpjust , i changed my code like you said.
I also liked to add a check if the letter is uppercase after a dot "." .
Im just not sure how to go about it.
Can i do the two things in one while() statement or shall i have to use two?
Can i use only getline() for the two or i need getline() and get()?
Should i use three files for it or i can do it with two?
Take File1 , uppercase every line , put it in File2
Take File2 , uppercase after "." put it in File3

Code:

#include <iostream>
#include <fstream>
#include <string>
#include <cctype>
using namespace std;


int main()
{
  cout << "Enter file name : ";
  string FileName;
  cin  >> FileName;
  ifstream TheFile(FileName.c_str());
  ofstream TheCopy;
  TheCopy.open ("Your_Uppercased_Copy.srt",ios::app);
  
  string str;
  size_t offset;
  
  while (getline(TheFile,str))
  {      
          str[0] = static_cast<char>( toupper(str[0]));
          TheCopy << str << endl; 
  }
  

  while((offset = TheFile.find(".")) != -1)
  {
          str =  put.(char( toupper(offset + 1));
           TheCopy << str << endl;          
  }
  TheCopy.close();  
  TheFile.close();
}

Code:

while((offset = TheFile.find(".")) != -1)

TheFile is a ifstream which doesn't have the find method. You can find things in a string. Then it would be wiser to compare against std::string::npos which may or may not equal signed value -1.

However, you should do all the capitalization before you output anything to TheCopy - in the first while loop where you actually have the string that you want to work with.

By the way, if this is normal text I'd expect a space after '.' unless there is a typographical error. If that is the case you might need to adjust your logic to find the first non-whitespace character after a full stop. You also fail to take into account that '.' may be the last character of the string.

What i cant seem to find is how to uppercase after two characters like ". " (dot and space).

To get this right... what you're saying is that given input like:

Code:

hello
.world
123 abc
5678

You expect output like:

Code:

Hello
.World
123 Abc
5678

Is this correct?