(char)x

[Ducky]

Whats wrong with this program? It compiles but it doesnt work.
I liked the program to replace the first letter of the string that the user type with an uppercase letter.
How can i put the ascii value that the letter at String[0] represents into "int x;"?
I tried every possible way that i could think of so i post here the simplest.

#include <iostream>
#include <strings.h>
#include <cstdio>
#include <cstdlib>
using namespace std;


int main()
{
 char String1[222];
 cout << "Enter string : ";
 cin  >> String1;
 char String[229];
 int   x;
 int   y;
 int   z;
 int   v;
 strncpy(String, String1, 222);

 if       ( String[0] >=  (char)97 || String[0] <= (char)122)
               
          {
            String[0]  =   (char)x;
            x - 32     ==  y;
            String[0]  =   (char)y;
          }    
              
            cout << "\n" << String << endl;

 system("PAUSE");
}

Thanks in advance

[cyberfish]

1. you don't need two strings, you can just modify the input string.

2. i don't get what the four integers are for

3. you don't need all the casts in:

 if       ( String[0] >=  (char)97 || String[0] <= (char)122)

there is a logical error in there too, the two clauses should be connected with AND
avoid magic numbers too while ur at it:

if (String[0] >= 'a' && String[0] <= 'z')

or better still:

if (islower(String[0]))

simpler still (since toupper() doesn't do anything if the character is already in uppercase):
the whole if could be replaced by:

String[0] = toupper(String[0]);

4. I'm clueless about whats happening here:

String[0]  =   (char)x;
            x - 32     ==  y;
            String[0]  =   (char)y;

did you mean:

String[0] -= 32;

?

5. why have different lengths for the two strings?

[Elysia]

This is C++, so I'd recommend using std::string instead of raw char arrays.

[Ducky]

"4. I'm clueless about whats happening here:
Code:

String[0] = (char)x;
x - 32 == y;
String[0] = (char)y;

did you mean:
Code:

String[0] -= 32;"
****************************************
I was trying to substract 32 from the ascii value of a lowercase letter to get the
uppercase correspondent.

Thanks for you both , i take good note of your responses.

[anon]

Assignment goes right-to-left: the value on the right is assigned to the variable on the left. == is a comparison operator, = is for assignment.

If you feel you need to cast x to char each time you use it, why didn't you declare it as a char in the first place? Anyway, a char is just an int with a smaller range and instead of a numeric value, a character symbol is used to represent it on output.

[Ducky]

I didnt declared x as a char because i wanted to get the ascii value of the letter,
and i didnt know how to do it by "String[0] = (char)x;"
But now i know that "Assignment goes right-to-left" so i should have done it back to front.

Cheers

[anon]

You don't need an int to get an ASCII value. A char type stores a small integer (the ASCII value) and only when it is output it will be treated in a special way (a character symbol is displayed). You can do all the math with it:

    char ch = 'a'; //== 97
    ch -= 32; //OK

[Ducky]

Wow thanks Anon, thats some useful information , i didnt know about that.