Thread: sqrtf function

Code:

distance = ((bx-ax)*(bx-ax)+(by-ay)*(by-ay)+(bz-az)*(bz-az));

Code:

#include <iostream>
#include <cmath>
using std::cout;
using std::endl;

float dist(float ax, float ay, float az, float bx, float by, float bz)
{
	float d = 0.0f, dist = 0.0f;
	
	dist = ((bx-ax)*(bx-ax)+(by-ay)*(by-ay)+(bz-az)*(bz-az));
	d = sqrtf(dist);
	cout << d << endl;
	return d;
}

I would recommend that you don't use the same name for a function and a variable inside the function. Whilst it's perfectly legal and valid to do, it can confuse almost any reader.

Of course, aside from debug purposes, there's no reason to calculate intermediate values at all - just stuff the whole computation into the arguments to sqrtf() and be done with it.

--
Mats

Did you edit the code in your original post?

Please don't do that. It confuses people who later read the thread.

Ah, I see what was wrong. I wondered how Dave got to the pink parts in his code. Didn't see the declaration.

Just proof of what matsp said.

My bad. I didn't really look at the function name, only the variable declared above the assignment which didn't seem to come from anywhere. The highlights were just my way of saying "look here". But I should have changed the variable declaration instead.