Quick question on exception handling

[ibleedart]

If I have this snippet of code in an implementation file:

    cout << "Please select from one of the following destinations (Enter the first letter only):" << endl;
    cout << "(C)hicago" << endl;
    cout << "(N)ew York" << endl;
    cout << "(D)enver" << endl;
    cout << "(O)rlando" << endl;
    cout << "(L)os Angeles" << endl;
    cout << "(R)eturn to Main Menu" << endl;																																				
    cin >> destination;
//==============Start of Exception handling=====================
    if (destination != "c" || destination != "C" || destination != "n" || destination != "N"
	|| destination != "d" || destination != "D" || destination != "o" || destination != "O"
	|| destination != "l" || destination != "L" || destination != "r" || destination != "R")
	throw str;
    }//==============end of try=============
    catch(string messageStr)
    {
	cout << messageStr << endl << endl;
	system("pause");
	cin.clear();
	cin.ignore(10,'\n');
    }//==============end of catch=============
    }//==============end of do===============

    cout << endl;

    if (destination == 'R' || destination == 'r')
        return;
    //==================Class Choice==================
  do
  {
    try
    {
    cout << "Will the customer be traveling First Class or Economy Class?" << endl;
    cout << "(1) First Class" << endl;
    cout << "(2) Economy Class" << endl;
    cin >> reserveType;
//=================Start of exception handling===================
    if (reserveType != 1 || reserveType != 2)
	throw str;
    }//==============end of try=============
    catch(string messageStr)

Can I use "messageStr" again in this next catch?

[Daved]

Yes, you can use the variable name messageStr. It's scope is limited to the catch block. However, it will be a completely separate variable with no relationship to the first one.

Are you doing this to learn exceptions? This code is generally not how you'd want to use them unless you are just trying things for learning purposes.

[ibleedart]

Yes, you can use the variable name messageStr. It's scope is limited to the catch block. However, it will be a completely separate variable with no relationship to the first one.

Are you doing this to learn exceptions? This code is generally not how you'd want to use them unless you are just trying things for learning purposes.

Yes, actually I am doing this for a final group project program. I saw the tutorial said that it's useful to create classes for exceptions as they occur, but seeing as we're trying to finish it up by midnight, I'm not going to go into too much more detail on this one. Thanks so much for your help!

[CornedBee]

Yes, actually I am doing this for a final group project program.

Er .. .I don't think that's what Daved meant by "learning purposes". But seeing as you've got a few hours left to finish, I suppose it's not a good time to scrap the whole component and start over.

[matsp]

Your code would be noticably easier to read [and write] if your comparisons use "tolower()" or some similar construction when you are looking at the input to see if it's a particular letter.

--
Mats

[brewbuck]

Your code would be noticably easier to read [and write] if your comparisons use "tolower()" or some similar construction when you are looking at the input to see if it's a particular letter.

--
Mats

How about:

if(std::strchr("cndolr", tolower(destination)) == 0)
{
    throw str;
}

Of course, "str" is a weird thing to be throwing...