confused with cin.getline()

**avgprogamerjoe** · 08-23-2007

I have made a if statement, and I know that it is carried through because the first cout in it is executed, and one I put at end to test.

Code:

using namespace std;    //namespace std

int i;
string line;            //initiate a string
vector<string> names;


int main ()

    {
        char string[256];

        std::string user_input;


        cout<< "Enter one to add name, or zero to continue: ";

        cin>> i;


        if (i == 1)
            {


                cout<< "please enter name: \n";

                cin.getline(string, 256);

                user_input = string;

                ofstream people ("example.txt", ios::app);     //open file

                people<< "\n" << user_input;       //write names


                people.close();          //close file, so it can be opened in read mode

                i = 0;
                cout<< "test"   // comes throuch
                cin >> i;         /// executes.

            }

Whats wrong with the program?

**hk_mp5kpdw** · 08-23-2007

You have not tested the file (error checking) to make sure it is opened successfully. You also need to logical-or (|) the ios::app with ios::out I believe.

There is also a string version of the getline function that you could use instead of what you're using:

Code:

getline(cin,user_input);

The explicit close of the people ofstream object isn't necessary but isn't hurting anything.

Beyond that what are you expecting to happen with the code?

**ArseNiC** · 08-23-2007

Yeah that doesn't exactly explain what error you get or what are you getting that you didn't expect?

**robwhit** · 08-23-2007

the string variable conflicts with std::string.

Code:

#include <iostream>
#include <fstream>
#include <string>
#include <vector>

the line you get in with getline is an empty string from the end of the line after you entered in the integer.

**scwizzo** · 08-23-2007

You should open the file directly, then check if the file was opened. Here is an example from one of my projects.

Code:

    ifstream file;
    
    cout<<"Enter file name: ";
    cin.getline(filename,45);
    
    file.open(filename);
    
    if(file.is_open()){
    
       file >> x[n] >> y[n];

**Daved** · 08-24-2007

>> You also need to logical-or (|) the ios::app with ios::out I believe.
For an ofstream, ios::out is automatic.

Thread: confused with cin.getline()

Thread Tools

Search Thread

Display

confused with cin.getline()

Similar Threads

cin.getline and msgrcv

why wont this compile?!? :confused:

confused.. in selecting my line of deapth

problem with cin.getline()