Switch statement help

**GeorgeV** · 08-06-2007

Hey guys, I've been mucking around with this or hours, to no avail. Hope you can help.

Basically, how the crap can I shorten this block of code? It works just fine how it is, but I've been assured it is possible to cut it right down in lengh. Somehow. I have tried cutting the case statements down to 15 in number, and changing the fourth line to read "switch (speed/2)", but when 31 is entered, the program returns $310 instead of "go to jail",

Anyway here's the source code:

Code:

 int main()
{int speed;
cout << "Enter speed in km/h: "; cin >> speed;
switch (speed)
{case 0:
case 1: 
case 2:
case 3:
case 4:
case 5:cout << "No fine applies" << endl; break;
case 6: 
case 7:
case 8:
case 9:
case 10:cout << "The fine is $20" <<endl; break;
case 11:
case 12:
case 13:
case 14:
case 15: cout << "The fine is $50" <<endl; break;
case 16:
case 17:
case 18:
case 19:
case 20:
case 21:
case 22:
case 23:
case 24:
case 25:
case 26:
case 27:
case 28:
case 29:
case 30: cout << "The fine is: $" << speed*10 << endl; break;
default: cout << "Go to Jail\n";
}

Thanks in advance,
George

**dwks** · 08-06-2007

I wouldn't use a switch statement. There are just so many duplicate values. This is much easier to read:

Code:

if(speed < 0 || speed > 30) {
    cout << "Go to Jail\n";
}
else if(speed < 5) {
    cout << "No fine applies" << endl;
}
else if(speed < 15) {
    cout << "The fine is $50" <<endl;
}
else {  /* speed < 30 */
    cout << "The fine is: $" << speed*10 << endl; break;
}

If you have to use a switch for some reason, you could always conserve vertical whitespace at the cost of horizontal whitespace by putting multiple cases on one line.

Code:

case 0: case 1: case 2: /* ... */

**GeorgeV** · 08-06-2007

Thanks for the prompt reply.

Yes that would be somewhat easier, but the requirements for this assessment state that a Switch statement must be used. I tried a combination of Switch and 'else if', but am not sure that's allowed either.

So, any way round this using *just* a switch statement?

**GeorgeV** · 08-06-2007

Sorry, missed the last part of your comment.

If all else fails I'll do that. Good idea.

**Darryl** · 08-06-2007

Originally Posted by GeorgeV

Thanks for the prompt reply.

Yes that would be somewhat easier, but the requirements for this assessment state that a Switch statement must be used. I tried a combination of Switch and 'else if', but am not sure that's allowed either.

So, any way round this using *just* a switch statement?

31 / 2 = 15 (in integer math).

instead of dividing by 2, how about trying ((speed - 1) / 5).

**iMalc** · 08-06-2007

Originally Posted by Darryl

31 / 2 = 15 (in integer math).

instead of dividing by 2, how about trying ((speed - 1) / 5).

Shh Shh, he said it was an assessment. (Of his ability, not ours)

**GeorgeV** · 08-07-2007

Hah! I had that figured out earlier today, but it wouldn't work. So it turns out I had the brackets all wrong - I only had one set enclosing the entire equation.

Thanks guys

Thread: Switch statement help

Thread Tools

Search Thread

Display

Switch statement help

Similar Threads

Mutli Switch statement help

Switch statement / default:

switch statement

char switch statement

Efficiency with the switch() statement...