Thread: Parse function not reading through entire vector

I've written this little member function to parse a vector's data, but it only parses the first LINE of data.
See, the vector reads in a multi-line file, each line with 3 parameters separated by a semi-colon.
The vector has all that unparsed data stored, so what this function does is read through it, and parse the data, placing the right segment of data in the correct array. My problem is my function doesn't seem to be iterating through the entire vector. ONLY the first line of the file that's stored in the vector is parsed (which I've checked and double checked by outputting the arrays the data is sent to, and outputting the data as it's parsed).
I am a bit rusty, and I'm confused as to why it's not running through the entire vector, as it seems to me that it should. Code below is the function:

Code:

void Map::parse_data()
{
  istringstream iss;
  string parsed;
  vector<string>::iterator iter;
  int counter=0;
  for(iter=data.begin();iter!=data.end();iter++)
    {
      iss.str((*iter));
      while(!iss.eof())
	{
	  getline(iss,parsed,';');
	  if(!parsed.empty())
	    switch(counter)
	      {
	      case 0:
		xsprcrds[xpos]=atoi(parsed.c_str());
		parsed.clear();
		xpos++;
		counter++;
		break;
	      case 1:
		ysprcrds[ypos]=atoi(parsed.c_str());
		parsed.clear();
		ypos++;
		counter++;
		break;
	      case 2:
		sprname[npos]=parsed;
		parsed.clear();
		npos++;
		counter=0;
		break;
	      }
	}
    }
}

Any help's appreciated, thanks.

Try changing this:

Code:

void Map::parse_data()
{
    istringstream iss;
    string parsed;
    vector<string>::iterator iter;
    int counter=0;
    for(iter=data.begin();iter!=data.end();iter++)
    {
        iss.str((*iter));
        while(!iss.eof())
        {
            getline(iss,parsed,';');
            if(!parsed.empty())

To this:

Code:

void Map::parse_data()
{
    string parsed;
    vector<string>::iterator iter;
    int counter=0;
    for(iter=data.begin();iter!=data.end();iter++)
    {
        istringstream iss;
        iss.str((*iter));
        while( getline(iss,parsed,';') )
        {
            if(!parsed.empty())

... and see if that helps.

Thanks for the reply.
That did help me a bit, now it reads through all the lines, but my problem's changed a bit.
Here's what the file that's being parsed looks like:

Code:

5;20;MidGreen
10;20;LeftGreen
30;20;RightGreen
...

And you get the picture.
Well anyways, now when I run the function that looks like this:

Code:

void Map::parse_data()
{
  string parsed;
  vector<string>::iterator iter;
  int counter=0;
  for(iter=data.begin();iter!=data.end();iter++)
    {
      istringstream iss;
      iss.str((*iter));
      while(getline(iss,parsed,';'));
        {
	  cout<<parsed<<endl;
	  if(!parsed.empty())
	    {
	    switch(counter)
	      {
	      case 0:
		xsprcrds[xpos]=atoi(parsed.c_str());
		parsed.clear();
		xpos++;
		counter++;
		break;
	      case 1:
		ysprcrds[ypos]=atoi(parsed.c_str());
		parsed.clear();
		ypos++;
		counter++;
		break;
	      case 2:
		sprname[npos]=parsed;
		parsed.clear();
		npos++;
		counter=0;
		break;
	      }
	    }
	}
    }
}

Notice the bolded line, I have this so I can see each piece of that file it parses.
Now when I run it, it should output EVERYTHING in pieces, right?
For example:
5
20
MidGreen
...
etc, right?
Well, what's happening is this:
MidGreen
LeftGreen
RightGreen
...
and it's skipping all the numbers which are very crucial. This strikes me as very odd, but I'm sure I have a slip-up somewhere in my code.
I appreciate your help greatly, and any future help as well!

EDIT:
Daved, the data vector size is 3 (I've cut the file it reads down to those three lines I've shown you above) and it runs the for loop 3 times, all seems in order there.

I'll incorporate that suggestion brewbuck, thanks for that.
Also, I've found the problem.
The problem was.... a stray semi-colon...
Notice in my last post, with the code of the current function, the while loop:

Code:

while(getline(iss,parsed,';'));

That single semi-colon prevent it from looping through and running more than just that first time because it ended that line.
That goes to show how much a single misplaced character can throw off a program, eh?
I feel really stupid right now, but I'm glad to have found and fixed the problem. Everything's working as it should. Thanks everybody!