Thread: To do with functions..

> loc[3][3] = 1;
Arrays start at 0, not 1
So your data should begin with
loc[0][0] =1;
and end with
loc[2][2] =1;

As for your error message, count your braces.
There's one more open brace in your main.

Which, if you had a decent approach to indentation would have been obvious.

If you indent your code properly, you would notice that there is a missing closing brace.

Also, you must remember that array indices begin at 0, not 1.You should probably use nested loops for your display() function too.

You can put whitespace into your code, you know.

Code:

cout<<"["<<loc[1][1]<<"]"<<"["<<loc[2][1]<<"]"...

->

Code:

cout << "[" << loc[1][1] << "]"
    << "[" << loc[2][1] << "]" ...

Indentation helps too.

Also:

Code:

cout<<"enter x then y value for player X\n";
cin>>x>>y;
cin.ignore();
if (loc[x][y] == 1){loc[x][y] = 8;};
;

If that if statement is false, perhaps you should ask the user for new coordinates. A loop would be useful here.

ohh you guys are so friendly! =D. i was expecting to get flamed big time..

anyway, this is what i did..

Code:

#include <iostream>

using namespace std;

void display(void);

 int loc[2][2] = 1;

int main()
{
    
    int x, y;
   

while (1){
cout<<"enter x then y value for player X\n";
cin>>x>>y;
cin.ignore();
if (loc[x][y] == 1){loc[x][y] = 8;}
else {cout<<"please enter new coordinates";
cin>>x>>y;};
display();
cin.get();

cout<<"enter x then y value for player O\n";
cin>>x>>y;
cin.ignore();
if (loc[x][y] == 1){loc[x-1][y-1] = 0;}
else {cout<<"please enter new coordinates";
cin>>x>>y;};
display();
cin.get();
}
}


void display(void)
     {
               
     cout<<"["<<loc[1][1]<<"]"<<"["<<loc[2][1]<<"]"<<"["<<loc[3][1]<<"]"<<"\n"
         <<"["<<loc[1][2]<<"]"<<"["<<loc[2][2]<<"]"<<"["<<loc[3][2]<<"]"<<"\n"
         <<"["<<loc[1][3]<<"]"<<"["<<loc[2][3]<<"]"<<"["<<loc[3][3]<<"]"; // this draws the grid
     }
    

}

but now it says:
"line 7 - invalid initializer"
"line 46 - expected deceleration before '}' token"


ohh, one quick question, can i just do that? int loc[2][2] instead of setting all of them individually?

ohh, one quick question, can i just do that? int loc[2][2] instead of setting all of them individually?

No, you cannot, and that is the current problem. In your main function, write something like:

Code:

int loc[3][3];
for (int i = 0; i < 3; ++i)
{
    for (int j = 0; j < 3; ++j)
    {
        loc[i][j] = 1;
    }
}

You can have an initialiser

Code:

int loc[3][3] = {
  { 1, 1, 1 },
  { 1, 1, 1 },
  { 1, 1, 1 },
};

You probably want something along these lines:

Code:

while (1)
{
    cout << "enter x then y value for player X\n";
    cin >> x >> y;
    cin.ignore();
    while (loc[x][y] != 1)
    {
        cout << "please enter new coordinates";
        cin >> x >> y;
        cin.ignore();
    }
    loc[x][y] = 8;
    display();
    cin.get();