Thread: Program closing, without any errors

Hallo,

I have a problem with my program. When I try to open it, it closes again, just like if I did not have system("PAUSE"); at the end. This did not happen until I tried to use my loadFromFile() function.

Any ideas on what is causing the trouble? I also tried to add a cin >>, but same thing happen.

Just so you know, the loadFileFunction is work in progress so please dont kill me for bad stuff in it.


Here is my main.cpp

Code:

#include <cstdlib>
#include <iostream>

#include "Material.h"
#include "Scene.h"
#include "Raytracer.h"
#include "Input.h"    // This is the only header I get info from now

using namespace std;

int main(int argc, char *argv[])
{
    cout << " OK raytracer " << endl;
    cout << " ---------------------------------------\n" << endl; 
    
    std::vector<Triangle> stuff;
    
    stuff = loadFromFile("c:\\testFile.txt");
    
    
    cout << "done" << endl;
    
    system("PAUSE");
    return EXIT_SUCCESS;
}

Input.cpp

Code:

#include "Input.h"
#include <iostream>
#include <string>
#include <fstream>
#include <windows.h>
#include <vector>
#include <sstream> 


std::vector<Triangle> loadFromFile(char* FileName)
{     
      std::string currentLine;            // Variable that holds the current line
                                          // we are using.
      int nrLines = 0;                    // Variable for checking how many lines 
                                          // there are in the file      
      
      // Open file
      std::ifstream myFile (FileName);
      
      if (myFile.is_open())
      {
          // While the file is open, we read the info and construct triangles
          while (! myFile.eof())
          {
              // Read line
              getline(myFile, currentLine);
              
              // Check if this line holds vertex information. If the line starts 
              // with V, we will use it.
              
              if (currentLine[0] == 'V')
              {
                  // Break the line into different components, so that we can
                  // create 3 different vertexes for each cordinate in the file
                  // V: 0.0,0.0,0.0 - 1.0,1.0,1.0 - 2.0,2.0,2.0
                  
                  // An array of strings, for reading the 3 vertexes we will later
                  // use
                  std::string vertex[2];

                  // Variable for keeping track of which character in currentLine
                  // we are reading, it starts at 2, as the 3 first characters
                  // are not part of the number we are tring to read
                  int x = 2;
                  
                  // Make a loop for creating 3 vertexes
                  for (int i = 0; i < 3; i++)
                  {
                      // Make sure the vertex string we are writing to now is 
                      // empty
                      vertex[i].clear();
                      
                      // Make sure the current character is part of the number
                      while (currentLine[x] != '.' || currentLine[x] != ' ')
                      {
                         // If the current character is part of a number,
                         // append it to the vertex string
                         vertex[i].push_back(currentLine[x]);
                         x++;
                      }
                      
                      std::cout << vertex[i] << "  ";  // Temp line for printing
                      x++;
                  }
                  
                  std::cout << std::endl;              // Temp line for printing
                  
                  // Convert the vertex arrays into numbers, so we can use them
                  // to create triangles.
                  
                  
              }

              // Increment the line counter
              nrLines++;
          }
          
          // Finished with reading the file, close it
          myFile.close();
      }
      
      
      
      // Read the cordinates of the three first vertexes
      // and pass them to a new triangle
      // Continiu this until file is finished
      // Return the vector array of triangles     
}

>> if (currentLine[0] == 'V')
Are there any empty lines in the file? If so, this could cause a crash, since currentLine would be empty and the element at index 0 won't exist.

>> std::string vertex[2];
This array has a size of 2, not 3. When declaring an array, the value inside the brackets is the size.

Originally Posted by Daved

>> if (currentLine[0] == 'V')
Are there any empty lines in the file? If so, this could cause a crash, since currentLine would be empty and the element at index 0 won't exist.

>> std::string vertex[2];
This array has a size of 2, not 3. When declaring an array, the value inside the brackets is the size.

No, there are no empty lines

here is my file:
random line 11 ra
V: 2.020,0.121,12.1212 4.657,11.31,9.11 4.7,11.00,5.411
V: 2.020,0.121,12.1212 4.657,11.31,9.11 4.7,11.00,5.411
V: 2.020,0.121,12.1212 4.657,11.31,9.11 4.7,11.00,5.411
V: 2.020,0.121,12.1212 4.657,11.31,9.11 4.7,11.00,5.411

have you tried running it in a debugger?

Well, I have tried, but I dont really know how to do debugging. No matter what I do I get told by my compiler that I have to activate debugging mode, to use any of the debugging tools. But activating it still gives me the same message.

Using dev-c++

Did fixing the string array help the problem?

>> while (currentLine[x] != '.' || currentLine[x] != ' ')
Also note that this will run forever (the expression is always true). Every character is either not equal to '.' or not equal to ' '.

Did fixing the string array help the problem?

I tried to change it to two (assuming you mean in my for loop?), but it did not help. Also, I dont think I need to do so, as I have < 3, not <= 3, so I will count 3 as false and dont do the loop. Or?

No, the problem is that your array only has room for 2 strings, not 3. I assume you wanted 3 since that is what your comments suggest, so you would want to change your array declaration to have a size of 3.

Note that this code:

Code:

for (int i = 0; i < 3; i++)

runs through 3 indexes even though you use <. It runs through the indexes 0, 1 and 2. These are valid indexes for an array of size 3, which again is what I assume you want. So leave the for loop the way it is and fix the size of the array.

Also, I edited my previous post with another observation which will also certainly cause a crash in your program.

runs through 3 indexes even though you use <. It runs through the indexes 0, 1 and 2. These are valid indexes for an array of size 3, which again is what I assume you want. So leave the for loop the way it is and fix the size of the array.

Also, I edited my previous post with another observation which will also certainly cause a crash in your program.

But vertex[2] is made up of [0],[1] and [2], or am I mixing something up here?

I changed the || to && (think that will be right?) but same thing happens, but thanks for pointing out

>> But vertex[2] is made up of [0],[1] and [2], or am I mixing something up here?
Yes, you are mixing up something here. This code creates an array of size 2:

Code:

std::string vertex[2];

That means the array holds only two elements. Valid array indexes go from 0 to size-1. So in that case, only vertex[0] and vertex[1] are valid. That's what I meant about the number inside the brackets being the size in the declaration. If you want elements vertex[0], vertex[1] and vertex[2] to be available, that means you want 3 elements, so you should declare your array to have a size of 3:

Code:

std::string vertex[3];

>> I changed the || to && (think that will be right?) but same thing happens
Yes, I think && is correct. Both the string array issue and this issue could have caused crashes, so both need to be fixed regardless. If you fix them both and you still get a crash, then maybe there is another error that we haven't seen yet.

Thanks for learning me that. I was so sure that the zero counted when creating an array, as it counts when you try to access elements of it. Better to learn it late than never.

But it did not fix the closing problem =\