Thread: Dynamically allocating memory...

Originally Posted by ZuK

That has beem pointed out earlier. (#2, #11). This works for g++ only.
You have to use

Code:

node *nodes = new node*[size];

Kurt

And what do you want to allocate here? array of structs or array of pointers?

It should be or

Code:

node *nodes = new node[size];

or

Code:

node **nodes = new node*[size];

alrighty, i'll give it a shot

It compiled!!!


But then it had a runtime error, segfault =( it didn't give me a readout of the variables though like it normally does, it pointed me to the vector header file. =(

Here it is:

Code:

#include <iostream>
#include <fstream>
#include <string>
#include <vector>

using namespace std;

struct node
{
	int data;
	node *next;
	node *prev;
};

struct circle
{
	node *start;
};

void createCircle(circle *circ, vector<int> &v);

int main()
{
	//Main
	circle *first;
	first = new circle;
	vector<int> numbers;
	for(int i=0; i<10; i++)
	{
		numbers.push_back(i+1);
	}
	createCircle(first, numbers);
	cin.ignore();
	//End
	return 0;
}

void createCircle(circle *circ, vector<int> &v)
{
	//create intitial node
	node *start;
	start = new node;
	start->data = v.at(0);
	//create the rest of the nodes
	int size = v.size();
	size--;
	//data
	vector<node*> nodes(size);
	for(size; size>=0; size--)
	{
		nodes.at(size) = new node;
	}
	size = v.size();
	size--;
	//Insert Data
	for(int i=0; i<size-1; i++)
	{
		nodes.at(i)->data = v.at(i);
	}
	//Connect nodes
	circ->start = start;
	start->next = nodes.at(0);
	for(int i=1; i<size-1; i++)
	{
		nodes.at(i-1)->next = nodes.at(i);
	}
	//do prevs
	start->prev = nodes.at(size-1);
	for(size-2; size>=0; size--)
	{
		nodes.at(size)->prev = nodes.at(size-1);
	}
	//DONE
}

well i know at() uses bounds checking which is why i prefer it as do most others, yeah it's obscure but if you were used to using .at() [] might look obscure too haha

okay, so i used a new variable and all and it stills throws the exception =(

Code:

size = v.size();
size--;
for(int i=0; i < size; i++)
{
     nodes.at(i) = new node;
}
...

Yeah its throwing an unhandled exception and if i click continue then an assertion error, the part it is showing me is in the vector.h file, _XRan or something, out of range memory location

alrighty, i'll give it a shot, thanks for the help!