problems converting char to int

**radiantarchon28** · 03-30-2007

here is my code

Code:

#include <iostream>
#include <stdlib.h>

using namespace std; // using standard namespace

int main ()
{
	char date[10], fname[20], lname[20];
	int d1, d2, m1, m2, y1, y2, y3, y4, year, day, month, ex1t;

	cout <<"enter 0 instead of your first name to exit"<<endl<<endl ;
	
	for (int x=1; x>0; x++)
	{
		cout <<"enter you first name: " ;
		cin >>fname ;
		ex1t=atoi(fname[0]);
		if (ex1t==0)
		exit(0);
		cout <<"enter your last name: " ;
		cin >>lname ;
		cout << "enter your birthdate in the format mm/dd/yyyy: " ;
		cin >>date ;
		d1=atoi(date[3]);
		d2=atoi(date[4]); 
		m1=atoi(date[0]); 
		m2=atoi(date[1]); 
		y1=atoi(date[6]);
		y2=atoi(date[7]); 
		y3=atoi(date[8]); 
		y4=atoi(date[9]);
		year=(y1*1000)+(y2*100)+(y3*10)+(y4);
		month=(m1*10)+(m2);
		day=(d1*10)+(d2);
		
		if ((month<12||month>1))

		if (month==(1||3||5||7||8||10||12)&&(day<32))
		cout <<lname <<", "<<fname <<", " <<date <<". "<< endl<<endl;

		if (month==(4||6||9||11)&&(day<31))
		cout <<lname <<", "<<fname <<", " <<date <<". "<< endl<<endl;
	}
	return 0;
}

and here are the errors

Code:

--------------------Configuration: program4 - Win32 Debug--------------------
Compiling...
program4.cpp
H:\program4.cpp(22) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(29) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(30) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(31) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(32) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(33) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(34) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(35) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
H:\program4.cpp(36) : error C2664: 'atoi' : cannot convert parameter 1 from 'char' to 'const char *'
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast
Error executing cl.exe.

program4.exe - 9 error(s), 0 warning(s)

what is im doing wrong?

**Daved** · 03-30-2007

atoi is used to convert a string to an int. If you have a single digit character and want to convert it to an int, simply subtract the zero character:

Code:

d1=date[3] - '0';

>> if (month==(1||3||5||7||8||10||12)&&(day<32))
That is not the correct use of multiple ||'s in an if statement.

I'd also suggest using C++ strings instead of character arrays. Among other benefits they won't require you to restrict the names to 20 characters.

**dwks** · 03-30-2007

Code:

char date[10];
/* ... */
d1=atoi(date[3]);

atoi takes a string, that is a char[], but you pass it a single character. The compiler complains about it.

Either use a 2D array, or . . . . Why not just cin directly into the numbers?

Code:

cin >> d1;
cin >> d2;
//...

or

Code:

cin >> d1 >> d2 >> // ...

Code:

if (month==(1||3||5||7||8||10||12)&&(day<32))

You can't do that. You need to use

Code:

if(month == 1 || month == 3 //...)

or a switch statement

Code:

switch(month) {
case 1:
case 3:
// ...
stuff;
break;  /* MUST have a break statement
    unless you want to experience the fall-though effect */
}

Code:

if ((month<12||month>1))

Don't you mean <=12?

Pray do tell, what is the purpose of this?

Code:

for (int x=1; x>0; x++)

[edit] Having a variable named "ex1t" is going to cause confusion. Call it "quit" or something else. [/edit]

**radiantarchon28** · 03-30-2007

to daved. im gonna try and use casting

to dwks.
1. its part of the assignment to use a char array
2. thanks for the tip on ||
3. i meant < 13
4. its an infinite loop. until the user chooses to exit it. (the user is not supposed to know before hand how many entries are to be made)(i always use for loops =habit)

**JaWiB** · 03-30-2007

Common variations of infinite loops are:

Code:

for (;;)
{
//...
}
while(true)
{
//...
}

Your loop isn't actually infinite since you're using a signed integer

**radiantarchon28** · 03-30-2007

well at least its going to run quite a few times. which is what i want

**dwks** · 03-30-2007

Originally Posted by radiantarchon28

to daved. im gonna try and use casting

to dwks.
1. its part of the assignment to use a char array

Okay. Then read in the whole line and use stringstreams (see the FAQ) to parse the numbers from it.

2. thanks for the tip on ||
3. i meant < 13

Same thing. <=12 would be easier to read, however, because people know that there are 12 months in a year, but when they see 13 they think, "what?".

4. its an infinite loop. until the user chooses to exit it. (the user is not supposed to know before hand how many entries are to be made)(i always use for loops =habit)

If you insist upon using a for loop take JaWiB's suggestion and use

Code:

for(;;) {
    // ...
}

**Daved** · 03-30-2007

>> to daved. im gonna try and use casting
I don't think that will work, but maybe you are talking about something different than what I'm thinking of. Can you give an example?

>> its part of the assignment to use a char array
A char array represents a string (string meaning a series of 0 or more characters, which is different than the C++ string class). atoi takes a character array that represents a string, but your code attempts to call atoi with a single character in the string.

**Noir** · 03-31-2007

Code:

cout << "enter your birthdate in the format mm/dd/yyyy: " ;
cin >>date ;
d1=atoi(date[3]);
d2=atoi(date[4]); 
m1=atoi(date[0]); 
m2=atoi(date[1]); 
y1=atoi(date[6]);
y2=atoi(date[7]); 
y3=atoi(date[8]); 
y4=atoi(date[9]);

Try this, it's a lot easier:

Code:

cout << "enter your birthdate in the format mm/dd/yyyy: " ;
cin >>date ;
date[2] = '\0';
date[5] = '\0';
month = atoi( date );
day = atoi( &date[3] );
year = atoi( &date[6] );

**Daved** · 03-31-2007

>> Try this, it's a lot easier
Easier, maybe, but it's doubtful that's a good idea for an assignment.

**Noir** · 03-31-2007

Why?

**Daved** · 03-31-2007

Because using it would be using a trick that is not normally taught in class. Also, given the OP's original code, I think it is unlikely that he or she would understand it very well and using a trick you got from the internet without understanding it kind of defeats the purpose of an assignment.

Thread: problems converting char to int

Thread Tools

Search Thread

Display

problems converting char to int

Similar Threads

C problem with legacy code

Converting a circulating mouse pointer to use a Potentionmeter

Okay, giant issue, I think I'm treading into territory outside of cboards maybe...

Personal Program that is making me go wtf?

I still don't get it