Thread: Problem with loading a file

I currently have this code for loading the contents of a file in a function,

Code:

	
void loadfile1() 
	{ 
		string line;

		cout << "File 1 - \n \n";
		ifstream infile("test.txt", ios::in); 
		while( !infile.eof() ) 
		{ 
			getline (infile,line);
			cout << line << endl;
		} 
		infile.close( ); 
	}

This code works fine when there is data in the file, but when there isn't it goes into an infinite loop.
I have tried a few things to fix it, but I think I just made it worse. Any ideas?

Thanks in advance.

Code:

string getfile()
{
	string line;
	string file;

	ifstream in ( "test.txt" );

	while ( getline( in, line ) )
		file += line + "\n";

	in.close();

	return file;
}

should return the whole file. Use it as follows:

Code:

int main( void )
{
	string test_file = getfile();

	cout<< test_file;

	return 0;
}

Obviously, I'm being dangerously minimalist with my error checking here. It's a bad idea to do that, so I'll leave it to you to add that in.

>> This code works fine when there is data in the file, but when there isn't it goes into an infinite loop.
That's because an empty file will cause the file stream to go into a fail state when you attempt to read with getline. You never check for a failed read, you only check for eof. You should use while (getline (infile,line)).

BTW, twomers' getfile function would probably be better using the method shown in this post: http://cboard.cprogramming.com/showp...23&postcount=5