c++ Pointers and the const keyword

[ncallaway]

Hello, I'm relatively new to C++. I've worked in C# and Java a fair amount, so I have a fairly decent understanding of programming concepts.

I've recently starting working on a mod for HL2 (not as anything commericial, just as a way for me to dive headfirst into c++ and start learning).

I've been playing for a few days, and I've run into an issue that I think (or, at least, hope) is language specific, and I don't quite grasp the symantics fully.

Anyway, I have a method of an object CBaseWeaponClip::SetMaxSize. It's code follows:

void CBaseWeaponClip::SetMaxSize( int maxSize ) {
   m_iClipSize = maxSize;

   // Clips hold at least a single bullet
   if ( m_iClipSize < 1 ) { m_iClipSize = 1; }

   if (m_iBulletsInClip > m_iClipSize) {
       m_iBulletsInClip = m_iClipSize;
   }
}

In another object I have a pointer

CBaseWeaponClip * c_cActiveClip

I found out that the pointer changing was causing several bugs (and it didn't need to be changing), so for safety I relabled my pointer:

CBaseWeaponClip * const c_cActiveClip

and changed other code using c_cActiveClip in that class appropriately.

However, now when I run the game it crashes and tells me "The memory at location [memory location] could not be read."

I tracked the problem to this function. Specifically changing it to:

void CBaseWeaponClip::SetMaxSize( int maxSize ) {
       return;
   /*m_iClipSize = maxSize;

   // Clips hold at least a single bullet
   if ( m_iClipSize < 1 ) { m_iClipSize = 1; }

   if (m_iBulletsInClip > m_iClipSize) {
       m_iBulletsInClip = m_iClipSize;
   }*/
}

allows the game to load and run correctly (except weapon clips are no longer implemented properly), because SetMaxSize is a critical function. I moved my "return" statement down one line:

void CBaseWeaponClip::SetMaxSize( int maxSize ) {
   m_iClipSize = maxSize;
   return;
   // Clips hold at least a single bullet
   /*if ( m_iClipSize < 1 ) { m_iClipSize = 1; }

   if (m_iBulletsInClip > m_iClipSize) {
       m_iBulletsInClip = m_iClipSize;
   }*/
}

and I recieved the crash again.

I got rid of the maxSize variable (well, it was still being passed), and simply assigned 5 to m_iClipSize:

void CBaseWeaponClip::SetMaxSize( int maxSize ) {
   m_iClipSize = 5;
   return;
   // Clips hold at least a single bullet
   /*if ( m_iClipSize < 1 ) { m_iClipSize = 1; }

   if (m_iBulletsInClip > m_iClipSize) {
       m_iBulletsInClip = m_iClipSize;
   }*/
}

and I still recieved the crash.

I am assuming (quite possibly incorrectly) that relabling my pointer "const" somehow is restricting me from modifying variables like m_iClipSize. Is this the case?
If so, what is the proper fix? (It this was "mutable" was designed for?)

If not, what am I missing, or what information do I need to include?

As an afterthough it may be important: I am running Windows XP, with the Visual Studio 2003 compiler.

Thank you for your time, and I appreciate any responses.

[CornedBee]

No, that's not what's happening. The pointer itself is const, not what it points to, so there's absolutely no restriction in what you can do with the pointee.

Seems more like for some reason, the pointer points into Nirvana, and the moment you actually access it by changing a member, it crashes.

[ncallaway]

Alright, then perhaps my error is in initalizing c_cActiveClip.

The only class that uses CBaseWeaponClip is CBaseClipHolder. In the header file I have:

class CBaseClipholder {
private:
        // ...
	CBaseWeaponClip * const c_cActiveClip;
	// ...
public:
        // ...
}

Then, the constructor for CBaseClipHolder:

CBaseClipholder::CBaseClipholder( void ) : c_cActiveClip() {
	m_iClipsHeld = 0;
	m_iAmmoType = -1;

	SetMaxClipSize(0);
}

Should create c_cActiveClip as a new CBaseWeaponClip (with no parameters passed). There is a constructor for CBaseWeaponClip that does not take any arguments, so that should be valid. Is there an error in here somewhere? Again, I think this is going to be a silly mistake on my part because I not that familiar with the language.

Anyway, I appreciate the time. Does it look like this pointer is going to "Nirvana", the great null in the sky, or wherever? Or have I possibly made a mistake elsewhere.

[Daved]

>> Should create c_cActiveClip as a new CBaseWeaponClip (with no parameters passed).
Actually it doesn't. c_cActiveClip is a pointer, and your code default initializes the pointer. That means it sets it to point to null.

You need to actually use new to create a CBaseWeaponClip and have c_cActiveClip point to it. Of course, I don't see any reason for c_cActiveClip to be a pointer, so in reality you don't need new at all. Just change c_cActiveClip to not be a pointer (and not be const) and things should work well.

[ChaosEngine]

just as a general point, I'd be wary of using the HL2 sdk as a jumping off point for learning C++.
While HL2 is technically hugely impressive, their code is not what I'd hold up as an example of correct, modern C++.

[ncallaway]

Yea, I'm fairly aware of that. I've done a little C++ before, and a lot of C# and Java, so I have a general idea of what clean code actually looks like.

I just wanted to get my hands dirty on someone elses code. Plus, I think it's a fun way to get into it.

[ChaosEngine]

Yea, I'm fairly aware of that. I've done a little C++ before, and a lot of C# and Java, so I have a general idea of what clean code actually looks like.

I just wanted to get my hands dirty on someone elses code. Plus, I think it's a fun way to get into it.

true. I built a "pet strider" mod 2 years ago when I was unemployed. it allowed you to tell the strider what to shoot with it's big cannon. wasn't much, but it was fun in single player!

you got a problem with me? let's see what my 60ft friend has to say about that... KABOOM!