Thread: count i++ not working corectly Help

This compiles w/o errors but I want it to tell me how many adults, teens, child and infant were entered. Right now, its only giving me a count of the number of functions. What am I doing wrong?

Code:

#include "stdafx.h"
#include <iostream>
using namespace std;

int _tmain(int argc, _TCHAR* argv[])
{
const int SIZE = 50;
int PeopleTypes[SIZE];
int count = 0, i = 0,infant = 0, child = 0,teen = 0, adult = 0;

do
{

cout<< "Enter a number: ";
cin >>PeopleTypes[i];


if (PeopleTypes[i]==1 )
cout <<"infant"<<i++<< endl;
else if (PeopleTypes[i]==2)
cout << " Child"<< i++ << endl;
else if (PeopleTypes[i]==3)
cout << "Teenager"<<i++<< endl;
else if (PeopleTypes[i]==4)
cout <<"adults at the school function"<<i++<<endl;
else
cout << "Invalid Entry!"<<endl;

}
while (PeopleTypes[i-1]>0);
i++;
	
return 0;
}

The i++ needs to be inside the loop, and you should be incrementing the appropriate counter in the if/else if statements instead of i.

You need to indent your code too, it makes it easier to read maintain and debug

I made corrections and tried different ways of writing the count, but now it does nothing. What am I missing?

Code:

#include <iostream>
using namespace std;

int _tmain(int argc, _TCHAR* argv[])
{
const int SIZE = 50;
	int PeopleTypes[SIZE];
	int count = 0, i = 0,infant = 0, child = 0,teen = 0, adult = 0;

do
{

cout<< "Enter a number: ";
cin >>PeopleTypes[i];


if (PeopleTypes[i]==1 )
cout <<"infant"<<infant++<< endl;
	else if (PeopleTypes[i]==2)
cout << " Child"<< child++ << endl;
	else if (PeopleTypes[i]==3)
cout << "Teenager"<<teen++<< endl;
	else if (PeopleTypes[i]==4)
cout <<"adults at the school function"<<adult++<<endl;
	else
cout << "Invalid Entry!"<<endl;

}
while (PeopleTypes[i-1]>0);
cin.ignore();	

return 0;
}

but now it does nothing.

whats 'nothing'? since its a 'do' loop it should 'do' something a minimum of one time, if it was just a 'while' loop, then its not guaranteed to loop at all.

What am I missing?

you initialize i to 0. now read this: while (PeopleTypes[i-1]>0);

i - 1 > 0 = true/false
0 - 1 > 0 = true/false
-1 > 0 = true/false
-1 > 0 = false

then you dont increment i anywhere, so it will run the loop once then exit.

Originally Posted by nadroj

whats 'nothing'? since its a 'do' loop it should 'do' something a minimum of one time, if it was just a 'while' loop, then its not guaranteed to loop at all.

you initialize i to 0. now read this: while (PeopleTypes[i-1]>0);

i - 1 > 0 = true/false
0 - 1 > 0 = true/false
-1 > 0 = true/false
-1 > 0 = false

then you dont increment i anywhere, so it will run the loop once then exit.

When I say nothing I mean the cmd window comes up, i type in 1 and the window disappears.

or if you are too lazy to open cmd, juz put

Code:

while(1) {}

just before return 0;

Originally Posted by jafet

Try actually opening cmd or some other shell, tryping the full path of your program into the prompt, and hit [Enter]. After the program has finished, there is nothing to keep it from closing immediately, and so it does. Read the FAQ for more info.

Thanks for the tip. I added this

Code:

std::cout <<"Press [Enter] to continue" <<std::endl;
  std::cin.get();

Originally Posted by nadroj

i copied and pasted your code (however i changed main signature to 'int main(void)') and it displays the cout. your not even getting the cout?
it does, as i mentioned, run once no matter what number you enter then exit. but i dont know why it doesnt work for you.. whats the _tmain thing? my guess is thats the problem, try changing it to the main signature i used (or any standard c++ one)

Thanks for the tip, that signature is a default or something with the visual studio.net version that I have. I changed it to int main ()