Thread: Can't seem to quite get this function to work...(should be easy)

Okay, so I have created a class MyString, and in it, I have a copyTo function. It has a starting position, an ending position, and the string it's supposed to be copied to.

Here's the function call from another class in the program:

Code:

 Address.CopyTo(0, atPosition, LocalPart.UserName);

Address is the whole string that I'm testing it, and LocalPart.UserName is a Mystring.

and here's the function itself:

Code:

void MyString::CopyTo(int startPosition, int length, MyString &destination)
{
	while( startPosition != length )
       {
             destination.Buffer[startPosition] = Buffer[startPosition];
             startPosition++;
	}

}

Buffer is a member of the MyString class, and the ONLY member, it is a char *

Whenever I try to do this, it comes out with length 71...which has nothing to do with any part of the program...at all.

Doing some random crap, I've gotten it to say 24, which is the size of the string I'm testing it with atm, but nothing to what it's supposed to be. :|

nope, that's not the problem, I did a debug statement to print atPosition...it's right (8 for this particular string).

Also, just to make sure, I hardcoded 8 into the call of copyTo

there's something wrong with the function...

it comes up with 71 as the length of the new string. the original is only 24...

alright, I got it, adding a NULL char at the end of the loop fixed it.

Thanks! you jsut saved my butt

IfYouSaySo, I understand what you're talking about with the vars...all Var names are specified by my professor, I have no control over that.

Sorry, for all of the replies next to each other, but there is something wrong with the function it seems, but it's getting the correct length now.

here's the function as it stands now, with a debug cout statement:

Code:

void MyString::CopyTo(int startPosition, int length, MyString &destination)
{
	while( startPosition != length )
    {
        destination.Buffer[startPosition] = Buffer[startPosition];
        startPosition++;
        cout << destination.Buffer[startPosition];
	}
    destination.Buffer[startPosition] = '\0';
    cout << endl;

}

and here's what it outputs:

╠╠╠
╠╠╠╠╠╠╠╠
sf
delphia

it SHOULD be:

asf
adelphia.net


wtf?

okay, here's what I have:

here's the test string:

"[email protected]"

I have these calls: The first just copies the string and prints it, the second gets everything before the @ (not including it), and the second gets everything after the @ (not including it).

Code:

Address.CopyTo(0, length, LocalPart.Strng);


   Address.CopyTo(0, atPosition, LocalPart.UserName);
   Address.CopyTo(atPosition + 1, length - atPosition - 1, Domain.Name);

atPosition is the location of the '@' symbol. Address is said String.

and here's my CopyTo functions:

Code:

void MyString::CopyTo(int startPosition, int length, MyString &destination)
{
	while( startPosition != length )
    {
        destination.Buffer [ startPosition ] = Buffer [ startPosition ];
        cout << destination.Buffer[startPosition];
        startPosition++;
	}
    destination.Buffer [ startPosition ] = '\0';
    cout << endl;

}

and here's the output:

[email protected]
asf
adhia

see, for some reason, it's not getting the '.net', yet if I print out the length for Domain.Name, it still prints 9 (which is correct)...


it SHOULD be:
[email protected]
asf
adhia.net

what could be going wrong here?


EDIT: I forgot to mention, if I try anything more positive than length - atPosition - 1 for the second CopyTo function call, it prints it out, but then crashes.