Thread: HexDump in C++

Prototype your functions before trying to call them.

Code:

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main()
{
	string filename;
	ifstream inData;
	ofstream outData;
	char buffer[1000];
	cout << "Enter the input file name: ";
	cin >> filename;
	outData.open("name1.txt");
	
	ifstream inData(filename, ios::binary);
	if (!inData.is_open())
	{
	   cout << "Unable to open file: " << filename << endl;
	   return 1;
	}

	inData.read(buffer, sizeof(buffer));
}
unsigned char lower(unsigned char c)
{
	unsigned char one_byte;
	one_byte = c & 0x0F;
	return one_byte;
}
unsigned char upper(unsigned char c)
{
	unsigned char one_byte;
	one_byte = (c & 0xF0) >> 4;
	return one_byte;
}

Now Ihave only this error...

1>------ Build started: Project: kok, Configuration: Debug Win32 ------
1>Compiling...
1>Source2.cpp
1>.\Source2.cpp(17) : error C2374: 'inData' : redefinition; multiple initialization
1> .\Source2.cpp(10) : see declaration of 'inData'
1>.\Source2.cpp(17) : error C2664: 'std::basic_ifstream<_Elem,_Traits>::basic_ifstrea m(const char *,std::ios_base:penmode,int)' : cannot convert parameter 1 from 'std::string' to 'const char *'
1> with
1> [
1> _Elem=char,
1> _Traits=std::char_traits<char>
1> ]
1> No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
1>Build log was saved at "file://c:\Documents and Settings\adzhagar\My Documents\Visual Studio 2005\Projects\kok\kok\Debug\BuildLog.htm"
1>kok - 2 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

there probably some thing wrong with ifstream inData(filename, ios::binary);.. but I don't know what.

You've got inData declared twice. Here:
> ifstream inData;
And here:
> ifstream inData(filename, ios::binary);
And you still haven't prototyped lower and upper. You must at least declare them before they are used. You can leave the definitions at the bottom, but you need a declaration at the top.

> ifstream inData(filename, ios::binary);
And this should be:
ifstream inData(filename.c_str(), ios::binary);

Code:

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main()
{
	char upper;
	char lower;
	char c;
	string filename;
	ifstream inData(filename.c_str(), ios::binary);
	ofstream outData;
	char buffer[1000];
	cout << "Enter the input file name: ";
	cin >> filename;
	outData.open("name1.txt");
	
	


	inData.read(buffer, sizeof(buffer));
}
char lower(char c)
{
	char one_byte;
	one_byte = c & 0x0F;
	return one_byte;
}
char upper(char c)
{
	char one_byte;
	one_byte = (c & 0xF0) >> 4;
	return one_byte;
}

hmm.. I think I doing some thing wrong with that upprt and lower...

also...

when I use this, this program

Code:

	if (!inData.is_open())
	{
	   cout << "Unable to open file: " << filename << endl;
	   return 1;
	}

It state that I cannot open the file...?

>It state that I cannot open the file...?
Then filename does not exist.

Did you initialize filename to be the name of your input file?