Thread: Memory leak in copying one char to another

Well, if you have a memory leak, maybe you're not deleteing something.

> for (int i = 0;i <= New->PathNumbers;i++, ActualPath++)
Well your loop probably goes one past the end. More likely it should be:

Code:

		for (int i = 0;i < New->PathNumbers;i++, ActualPath++)

> strcpy( &Path[i], &New->Paths[i] );
And unless Path and New->Paths are arrays of char *, this statement doesn't make much sense. If you are just copying one char, at a time, you would use:

Code:

Path[i] = New->Paths[i];

But then you would need to terminate the char array at the end with of the for-loop with:

Code:

Path[i] = '\0';

I would guess that the code is intended to break up a list of paths (like "C:\windows;C:\windows\system") into Paths[]? Or maybe just count how many paths are in Path? Or am I completely off?

It isn&#180;t still working as i want, when i have like "Dir1;Dir2;Dir3", even with the strcmp, it thinks that there is no ';', so it don&#180;t download only "Dir1", but download all the string.

Code:

typedef struct {
	float Version;
	int PathNumbers;
	char *Paths[60];
} sFile;

char *Path[60];

...

sFile *New;

ActualPath = 0;
	do{
		for (int i = 0;i < New->CharNumbers;i++, ActualPath++)
		{
			if ( strcmp(";", (const char*)New->Paths) == 0 )
			{
				ActualPath++;
				i++;
				goto Download;
			}
			Path[i] = New->Paths[i];
		}

Download:
		if ( pDownloader->DownloadFile( (const char*)Path, (const char*)Path ) != 0 )
                           return ERROR;
	}while ( ActualPath < New->CharNumbers );

Originally Posted by Scarvenger

It isn´t still working as i want, when i have like "Dir1;Dir2;Dir3", even with the strcmp, it thinks that there is no ';', so it don´t download only "Dir1", but download all the string.

Well, that's closer to stating your actual intent. Posting a small but complete and compileable snippet of code that demonstrates the problem will only get you an answer more quickly.

So... you're trying to parse a semicolon-delimited string?
Parsing a String into Tokens Using strcspn 2

Consider a break instead of the goto.