Very new to this.

**jsmagus** · 06-18-2006

I've only been experimenting with programming for about 3 days, so please be kind. I am just playing around trying to make a program to learn stuff, but this doesn't do what I want it to. Can someone point me in the right direction, of what I am doing wrong?

I basically want the user to input the correct answer before moving on.
Sorry if this seems stupid.

Code:

#include <iostream.h>
#include <stdlib.h>

int main()
{
   // My first attempt at a program
   char  ans1[6]="";
   char  ans2[6]="";


   cout<<"Here is my first program. Answers are one word, and lowercase.\n Enjoy!",endl;
   cout<<"  \n";

   cin.get();

   do{

   cout<<"What has a bed, but doesn't sleep?\n A mouth, but doesn't talk? \n", endl;
   cout<<"and a head, but doesn't think?\n", endl;
   cout<<"\n\n";
   cout<< "Answer: ";

   cin>> ans1;


          if (ans1 != " river ")
             cout<<"\nPlease Try Again\n", endl;
          }


    while (ans1 != " river ") ;

       cout<<"CORRECT!", endl;


      cin.get();

  //Next question

  do{

  cout<<"I can only do my job when my head is struck,\n","What am I?\n", endl;
  cout<<"Answer: " ;

  cin.getline(ans2,10);
      if (ans2 != "match")
      cout<<"Please Try Again\n", endl;      }

    while(!(ans2 == "match"));
           cout<<"CORRECT!", endl;

        cin.get();

    cout<<"Thank you for playing!", endl;

    cin.get();
}

Thanks.

**bumfluff** · 06-18-2006

It would help to say what is going wrong and where you think it is happening, or any error messages that you have.

**jsmagus** · 06-18-2006

Right, sorry.

Right now, no matter what answer is typed, the program outputs
"Try again." displays the question again. Even if you type the correct answer.

**whiteflags** · 06-18-2006

Your answer has whitespace which would rarely or never be a part of the answer string. Change " river " to "river" and it should work just fine.

Also be careful with your logic

Code:

while(!(ans2 == "match"));
           cout<<"CORRECT!", endl;

This essentially means that when we don't guess match, we were told we were wrong and right. Over and over.

**Wraithan** · 06-18-2006

First, you are using a depricated header,

Code:

#include <iostream.h>

should be

Code:

#include <iostream>

secondly, your not declaring

Code:

using namespace std;

which I believe you didn't have to set with with old iostream.h. Next your cout's are improperly syntax'd.

Code:

cout<<"What has a bed, but doesn't sleep?\n A mouth, but doesn't talk? \n", endl;

should be

Code:

cout<<"What has a bed, but doesn't sleep?\n A mouth, but doesn't talk? \n"<<endl;

notice the << instead of , . you separate strings/other stuff in a cout with << .

It is a wonder your program is even compiling, if I may ask, what compiler are you using?

Something else, endl flushes the output buffer and also inserts a \n, you do not need it at the end of every cout but at the end of a block of couts (even then, it isn't required).

http://www.cplusplus.com/ref/iostrea...eam/_endl.html

**jsmagus** · 06-18-2006

Thanks for all the help.
I'm using Bloodshed DEV-C++.

**Wraithan** · 06-18-2006

What version of it? If you are not running 4.9.9.2, you should go download that, I also use Dev-C++ and that is how I noticed all those syntax errors when I went to compile.

**jsmagus** · 06-18-2006

Thanks, I will download the newer version.

**Daved** · 06-18-2006

>> First, you are using a depricated header, #include <iostream.h>.

Something deprecated by the standard will still work with all standards compliant compilers. But <iostream.h> is not deprecated, and is not part of the standard at all. It already doesn't work on some modern compilers.

**atla** · 06-22-2006

One other thing:

Code:

   cin>> ans1;


          if (ans1 != " river ")
             cout<<"\nPlease Try Again\n", endl;
          }


    while (ans1 != " river ") ;

       cout<<"CORRECT!", endl;

should be

Code:

   cin>> ans1;


          if (ans1 != " river ")
             cout<<"\nPlease Try Again\n", endl;
          }


    while (ans1 == " river ") ;

       cout<<"CORRECT!", endl;

if ans1 != river; while ans1 == river

You had both as !=

**King Mir** · 06-22-2006

Originally Posted by atla

One other thing:

Code:

   cin>> ans1;


          if (ans1 != " river ")
             cout<<"\nPlease Try Again\n", endl;
          }


    while (ans1 != " river ") ;

       cout<<"CORRECT!", endl;

should be

Code:

   cin>> ans1;


          if (ans1 != " river ")
             cout<<"\nPlease Try Again\n", endl;
          }


    while (ans1 == " river ") ;

       cout<<"CORRECT!", endl;

if ans1 != river; while ans1 == river

You had both as !=

No it is correct as it is. jsmagus wants to print out "Please Try Again" and restart the loop if the answer is wrong.

The indenting in this code is horrible though.

**laserlight** · 06-22-2006

Maybe that part is better rewritten as:

Code:

for (;;)
{
	cin >> ans1;
	if (ans1 == "river")
	{
		cout << "CORRECT!" << endl;
		break;
	}
	else
	{
		cout << "\nPlease Try Again\n" << endl;
	}
}

Of course, this assumes that ans1 is actually a std::string instead of a char[6]. If not, strcmp() should be used... and there's the issue of what happens if the user (wrongly) guesses a word more than 5 characters.

**Desolation** · 06-22-2006

Of course, this assumes that ans1 is actually a std::string instead of a char[6]. If not, strcmp() should be used... and there's the issue of what happens if the user (wrongly) guesses a word more than 5 characters.

I was about to point that. It is amazing that nobody noticed that the OP used the == operator to compare C-style strings.

Use the strcmp() function as pointed by laserlight.

Thread: Very new to this.

Thread Tools

Search Thread

Display

Very new to this.