Thread: No errors just doesn't do what its supposed to.

Sorry about posting the entire code, I just read the FAQ. If it helps I think my problem is after the last void. Its not reading the file like I think it should be. Maybe I am just doing it wrong.

In your main() function, you call

Code:

myFileReader.reset();

This resets your FileReader object each time in the loop, which resets word_counter (hence it always prints 0).

Remove that line, and put reset() at the end of your menu() function instead.

Thanks that worked wonderfully. Now I need to try and finish by printing each word and the number of occurences of each word in the test.txt file!!!

Thanks again.

Originally Posted by jxmuller

DOH: I just noticed that the word count is always off now by +1. If I have 10 words it says 11. If I have 5 words it thinks I have 6. I will try to figure this one out.

In your file_count() member function, change

Code:

    while(!infile.eof())
    {
        infile >> temp;

to

Code:

    while( infile >> temp )
    {
        match = false;

Now the problem is my program is not ignoring words located in the ignore.dat file. Option 2 allows me to enter words to be ignored and that works fine (the file is created and words are added). But when I am trying to match words I suppose my logic is incorrect.

Are your ignored words loaded correctly? You might want to print the values of the ignored_words vector.

Also I would also change

Code:

    while(!infile.eof())
    {
        while(getline(infile, temp));
        ignored_words.push_back(temp);
    }

to

Code:

while( getline(infile,temp) ) 
  ignored_words.push_back(temp);

while( cin >> temp ); would work for both cases (newline or spaces), I believe.

I have changed a few things around (ultimately I still have what I started with) and nothing seems to get this thing to ignore words from ignore.dat

I am about to die trying to figure this out. Soon I will be pushing daisies.

May-be you could post what you have changed...

Do you set the word_counter to 0 before each count? ... Ah, you have it in the reset member - you don't need it. Hide the need to reset the value explicitly.

Also, I don't understand why you want to print the word count in the menu method. Wouldn't it make more sense to display it right after you have counted them?

Yes the counter is reset before each count. here is my current code:

Code:

#include<iostream>
#include<cstdlib>
#include<fstream>
#include<iomanip>
#include<cctype>
#include<string>
#include<vector>
#include<cstdlib>
using namespace std;

class FileReader
{
public:

    FileReader(){counted=false, word_counter=0;}
    void reset();
    void load_ignore_file();
    void add_ignore();
    void file_count();
    int menu();

private:

    bool counted;
    int  word_counter;
    ifstream infile;
    ofstream outfile;
    vector<string> ignored_words;
};


char quit();
void menu_option_error();


int main()
{
    FileReader myFileReader;

    myFileReader.load_ignore_file();

    char choice = 0;

    do{


        switch(myFileReader.menu())
        {
            case 1: myFileReader.add_ignore();
                    break;
            case 2: myFileReader.file_count();
                    break;
            case 3: choice = quit();
                    break;
  default: menu_option_error();
        }

    }while(choice!='Y');

return 0;
}



//FUNCTION DEFINITIONS

int FileReader::menu()
{
    int choice;

    system("clear");

    cout    << endl
            << setw(40) << "          MENU            \n"
            << setw(40) << " ------------------------ \n"
            << setw(40) << "  1. Add an ignore word   \n"
            << setw(40) << "  2. Perform File Count   \n"
            << setw(40) << "  3. Quit                 \n"
            << setw(40) << " ------------------------ \n";
    if(counted)
    {cout   << setw(30) << " Word Count = " << word_counter
            << setw(38) << "|\n"<< setw(38)
            << "------------------------";}
    cout    << endl
            << "Enter choice: ";
    cin       >> choice;
    counted=false;
    cin.ignore(80,'\n');
    reset();
    return choice;
}





void menu_option_error()
{
cout << "\n\n\t\aT'was not a valid menu option!  (Try Again)";
    cout << "\n\n\tPress [ENTER] to continue...";
    cin.get();
}

char quit()
{
    char yes_no;

    cout << "\n\n\tAre you sure you want to quit? (Y/N): ";
    cin  >> yes_no;
    cin.ignore(80,'\n');

    system("clear");

    cout << endl << endl;

    return toupper(yes_no);
}


void FileReader::reset()
{
    bool counted = false;
    word_counter = 0;
}

void FileReader::load_ignore_file()
{
    string temp;

    infile.clear();

    infile.open("ignore.dat");

    if(infile.fail())
       return;

    while( getline(infile, temp) )
    {
        ignored_words.push_back(temp);
    }

    infile.close();
}



void FileReader::add_ignore()
{
 string temp;

    outfile.open("ignore.dat",ios::app);
 if(outfile.fail())
    {
        cout << "\n\n\t\aOUTPUT FILE WRITE FAIL!"
             << "\n\t(Program will now terminate)"
             << "\n\n\tPress [ENTER] to Continue...";

        cin.get();

        exit(1);
    }

        cout << "\n\n\n\tEnter word to be ignored: ";
        cin  >> temp;

        temp += ' ';

        outfile << temp;

        outfile.close();
}


void FileReader::file_count()
{
    bool match;

    string temp;
    int back = ignored_words.size();


    cout << "\n\n\tExample:  C:\\myfile.txt"
         << "\n\t-------"
         << "\n\n\tEnter the path to your file to count: ";
    cin     >> temp;

    infile.clear();
    infile.open(temp.c_str(),ios::in);

    if(infile.fail())
    {
        cout << "\n\n\t\aCannot Locate File -OR- File Does Not Exist!"
             << "\n\n\tPress [ENTER] to continue...";

        cin.ignore();
        cin.get();

        return;
  }

    infile.clear();

 while( infile >> temp )
    {
        match = false;

        for(int c=0; !match && c<back; c++)

            if(temp == ignored_words[c])

                match = true;

        if(!match)

            word_counter++;
    }

    infile.close();

    counted = true;

}

The last few lines is where my problem is I just dont see it. It is not ignoring words in the ignore.dat file.