Thread: whats wrong here?

It only returns the first line of the text file over and over again. Why?

Code:

					//read a file.
					FILE *t;
					 long lSize;
					char * buffer;
					char *l;
					int i = 0;
					//read a file.
					t = fopen("test.txt","rb");
					if (t!=NULL) {
						fseek (t , 0 , SEEK_END);
						lSize = ftell (t);
						rewind (t);
						buffer = (char*) malloc (lSize);
						fread (buffer,1,lSize,t);
						l = strtok(buffer,"\r\n");
						while(l != NULL) { 
							if (strlen(l)>0) {
								dccfsend(cSock,"%s\r\n",buffer);
								l = strtok(NULL,"\r\n");
							}
						}
						fclose(t);
						free (buffer);
						remove( "test.txt" );
					} else dccfsend(cSock,"File Not Found: %s\r\n", arg);

I think that it might be here. Kind of subtle

Code:

						l = strtok(buffer,"\r\n");
						while(l != NULL) { 
							if (strlen(l)>0) {
								dccfsend(cSock,"%s\r\n",buffer);
								l = strtok(NULL,"\r\n");
							}
						}

The second parameter is a set of all the delimiters, not a string that can be used as a delimiter.

Originally Posted by Tonto

I think that it might be here. Kind of subtle

Code:

						l = strtok(buffer,"\r\n");
						while(l != NULL) { 
							if (strlen(l)>0) {
								dccfsend(cSock,"%s\r\n",buffer);
								l = strtok(NULL,"\r\n");
							}
						}

The second parameter is a set of all the delimiters, not a string that can be used as a delimiter.

Thank, it was here
dccfsend(cSock,"%s\r\n",buffer);
not buffer but l it should be.

Yeah, that makes more sense.