Thread: Malfunctioning Getch

Ok, so I use 8 for the array size and almost every problem goes away - except it still doesn't pause for the getch.

Tested your code (modified to use the standard headers) on the MinGW port of GCC 3.4.2, and the program works as I would expect it to.

So then, other than cin, is there any other functions that could pause the program for me? Having to stop it with cin seems, I don't know, kind of primitive...

getch() is rather 'primitive'. If you want something more 'advanced', you can #include <limits>, then write:

Code:

std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
std::cin.get();

The cin.ignore() discards whatever characters may remain on the buffer, then cin.get() waits for the enter key to be pressed.

It says that qualifier std is not a class or namespace name... do I just have an old limit library, or is there something else I"m missing?

hmm... perhaps you could test with:

Code:

#include<iostream>
#include<string>

using namespace std;

int main()
{
	string s;
	cout << "Please enter your first name followed by a newline\n";
	cin >> s;
	cout << "Hello, " << s << '\n';
	return 0; // this return statement isn't necessary
}

Does Borland 5 even support new-style headers? Does this compile?

Code:

#include <iostream>

int main()
{
  std::cout << "Hello, World!\n";
}

The '98 C++ standard was only included in version 5.5.

A workaround can be found here for your 5.02 version

If I write in the other line of that test segment with the using namespace std, by inserting #include <string>, it gives me a completely different set of errors: "'cin' is not a member of 'std'," "'streamsize' is not a member of 'std'," and two other errors around the two-line alternative to getch suggested that I suppose derive from these

I see. What I suspect is that <limits> is not implemented by your pre-standard compiler, or is implemented out of the std namespace. As such, when you #include <limits>, std is not defined, so the compiler complains.

Then, it looks like your compiler did implement std::string in the std namespace, and that is included when you #include <string> (as is standard). But when you first triest a using namespace std directive, you did not include that standard header, so again the std identifier was not defined.

If you cannot use the workaround that Mario F. suggested, you can go for a poor man's solution:

Code:

cin.ignore(1000, '\n');
cin.get();

The reason for std::numeric_limits<std::streamsize>::max() is to get the maximum size of the stream, and then discard as many characters as the stream can hold, or until the first '\n'. In this case, I have substituted for 1000, or whatever number you think is guaranteed to be less than what the user may type after the valid input.

Or you can just switch compilers.

Dev-C++ MinGW GCC

Originally Posted by seasali

Your compilator cannot communicate correctly with conio.

I've got to write that down somewhere once I stop laughing long enough.

Originally Posted by seasali

Instead "#include <conio>" use "#include <conio.h>

Nobody in this thread has used #include <conio> to my knowledge.

Ok, back to business:

Code:

void average_scores(double scores[], int length)
{  double sum, average;

	scores[0] = 0;
	scores[length] = 0;
   sum = 0;

   for(int m = 0; m < length; ++m)
   	sum = sum + scores[m];

   average = sum / (length - 1);

   cout << endl << "The average score given is: " <<
   	setiosflags(ios::showpoint|ios::fixed) << setprecision(2) << average << endl;
   getch();
}

What on earth do you expect that to do? Why do you clobber the first score, and then write to scores[length], which is out of bounds as people told you earlier?
First, arrays in C (and C++) start at index 0. Hence scores[0] is the first item. If you declare an array as double scores[10], it has ten doubles: the first is scores[0], the last scores[9].
Now, to rewrite your function:

Code:

void average_scores(double scores[], int length)
{
	double sum = 0, average;

	for(int m = 0; m < length; ++m) sum += scores[m];
	average = sum / length;

	cout << endl << "The average score given is: " <<
   	setiosflags(ios::showpoint|ios::fixed) << setprecision(2) << average << endl;
   getch();
}