Thread: Program taking up 100% of everything

I made this little program that prints out a random line from a file, but whenever I run it (under Windows) the CPU jumps to 100% and it takes up a lot of RAM, and then it ends without outputting anything. Under BSD (FreeBSD, from a shell account) it runs out of memory \very\ quickly. I have yet to try it under Linux but I would expect the same results. I have no idea why it is doing that, and I don't know where else to turn.

The code is attached since posting it messed up the tables because I indent with tabs.

getline's default delimiter is a newline. it will read up to the newline and put all that into the string. getline also removes the newline from the stream, so it will not showup in your string. Also you are returning a pointer to a local variable of random. the vector goes out of scope when your function returns. These may not be the solution, but they are problems.

Ah, ok, I was wondering about all those pointers and the scope of them in random.

Regaurding the getline-removing-newline-char, what alternative would I use, or how would I use getline to keep the \n?

Thanks for all the help so far, I'll start fixing the problems pointed out.

>> I've also seen something called random_shuffle talked about before that could randomize the vector.

I don't have time to look at the attachment right now, but random_shuffle is standard and can be used with a vector: std::random_shuffle(vec.begin(), vec.end()); You should #include <algorithm>.