Thread: <fstream> again !!!!!

I'm using fstream to load a *.txt file with about 1.3 MB of text. I have a

Code:

char		text[10000];
ifstream	fin;

Since whole file can't be put into "text[10000]", i'm doing it multiple times

Code:

while(true)
{
	fin.read(text, 9999);
	text[9999] = NULL;
	... writing this text somewhere
	if(fin.eof())break;
}

The problem is that "fin.read()" refuses to read the text last time, I have loaded
varius files, and it always skiped reading last time. And eof() returns true no matter
"fin.read" refused...

Is there a solution to this???

Are you zeroing out the buffer after each read, because here is what I suspect is happening.
You read in 9999, write it, read in another 9999 overwriting old data. Now when it gets to the leftovers at the end of the file that is less that 9999, (for instances, let's say 100), it's reading those 100 and overwriting the first 100 of the last 9999. Thus when you look at the end of what you wrote you are thinking, where is the end of my data? (it's at the beginning of this 9999 block)

I believe read returns number of bytes read, you could use that number to place your terminating null instead of just blindly at 9999, that way the last read will work... or you can 0 out in between, but that will be a little slower.

wow, no offense meant, but that's a terrible loop... something better would be:

Code:

while(fin.read(text,9999))
{
	text[9999] = NULL;
	// ... writing this text somewhere
}

but that looks really strange anyway, and I'd probably use

Code:

char ch;
while(file.get(ch))
{
	// ... writing this text somewhere
}

null != 0

you probably wanted to say: buffer[count]='\0';

...and please avoid usimg macros... instead of using #define BUFSZ 100, use const short int BUFSZ=100; in main.

Originally Posted by Darryl

Are you zeroing out the buffer after each read, because here is what I suspect is happening.
You read in 9999, write it, read in another 9999 overwriting old data. Now when it gets to the leftovers at the end of the file that is less that 9999, (for instances, let's say 100), it's reading those 100 and overwriting the first 100 of the last 9999. Thus when you look at the end of what you wrote you are thinking, where is the end of my data? (it's at the beginning of this 9999 block)

I believe read returns number of bytes read, you could use that number to place your terminating null instead of just blindly at 9999, that way the last read will work... or you can 0 out in between, but that will be a little slower.

That's not happening. I'm not an idiot...
Heres what i found on MSDN:

Code:

The unformatted input function extracts up to count elements and stores them in the array beginning at _Str. Extraction stops early on end of file, in which case the function calls setstate(failbit). In any case, it returns *this.

Originally Posted by ElastoManiac

That's not happening. I'm not an idiot...
Heres what i found on MSDN:

Code:

The unformatted input function extracts up to count elements and stores them in the array beginning at _Str. Extraction stops early on end of file, in which case the function calls setstate(failbit). In any case, it returns *this.

Ok, I am an IDIOT. I fixed the problem.
I can't belive how stupid i am.............