what is the error please? HELP??

**gtr_s15** · 12-09-2005

hi can some one note out what is wrong with this code:

Code:

int ifEven(string str)
{
    string array[15];
	int i=0;
	int k=0;
	
    while(i<str.size()-1)
    {
        array[k]=str.substr(i,2);
		cout<<array[k]<<" ";
		i+=2;
		k+=1;
	}		 
	for(int i = 0; array[i]; i++)
	{
       cout<<array[i];
    }    
	    
}

the error come out is:

function `int ifEven(std::basic_string<char, std::char_traits<char>, std::allocator<char>:

could not convert `array[i]' to `bool'

**Raven Arkadon** · 12-09-2005

for(int i = 0; array[i]; i++)

the second argument of the for statement requires a condition - so something that evaluates to true or false (thus bool).

array[i] is a string. you probably want
for(int i = 0; i < sizeof(array); i++)

**SlyMaelstrom** · 12-09-2005

My guess:

Code:

for(int i = 0; array[i]; i++)

This is supposed to be your condition to exit the loop. It's supposed to be boolean. It's an integer, and you'd end up crashing your program when it goes out of the bounds of it's size.

**gtr_s15** · 12-09-2005

do you mean like this?

Code:

int ifEven(string str)
{
    string array[15];
    char something[]="ABCDEFGHIJKLMNOPQRSTUVWXYZ";
	int i=0;
	int k=0;
	
    while(i<str.size()-1)
    {
        array[k]=str.substr(i,2);
		cout<<array[k]<<" ";
		i+=2;
		k+=1;
	} 
	for(int i = 0; i < sizeof(array); i++)
	{
       cout<<array[i];
    }    

}

**gtr_s15** · 12-09-2005

this code crash the program...

**SlyMaelstrom** · 12-09-2005

Code:

int ifEven(string str)
{
    string array[15];
    char something[]="ABCDEFGHIJKLMNOPQRSTUVWXYZ";
	int i=0;
	int k=0;
	
    while(i<str.size()-1)
    {
        array[k]=str.substr(i,2);
		cout<<array[k]<<" ";
		i+=2;
		k+=1;
	} 
	for(int i = 0; i < 15; i++)  // Size of the array. Don't bother using the
	{                            // size of function.
       cout<<array[i];
    }    

}

**Raven Arkadon** · 12-09-2005

ooops, sizeof() returns the size of the array in bytes...
you need to divide it by the size of one element:

replace sizeof(array) by
sizeof(array) / sizeof(*array)
or simply:
15

edit:
using the sizeof method allows changing the size of the array without having to change any code (except for the definition of array)

of course sizeof won't work with dynamic memory

**SlyMaelstrom** · 12-09-2005

Code:

#include <iostream>

using namespace std;

int main() {
  int array[10];
  
  cout << sizeof(array) << endl;
  cout << sizeof(array) / sizeof(int);
  cout << sizeof(array) / sizeof(*array); // As suggested by Raven Arkadon
                                          // This is good if you don't know your array's
                                          // datatype
  
  return 0;
}

// OUTPUT
// 40
// 10
// 10

**7stud** · 12-09-2005

gtr_s15,

When are you going to post some code you wrote? That is the code someone wrote for you in another thread.

You seem to think you can con people into writing your whole program for you.

**gtr_s15** · 12-10-2005

thank you for helping but i have one error that makes me really headache...

the problem is

i want to change each number in string to character that i had assigned as char something[]="ABCDEFGHIJKLMNOPQRSTUVWXYZ";.
for people who dont understand what i mean, here is an example,

array[0]=44, array[1]=11, array[2]=00, array[3]=13, so this is the fomula tat i want to use :
output for 44 is (44-26)+65 = 83, for character 83 = s, for 11 is 11+65 = 76 is character L, 00 is A because 00+65, and the last is 13 + 65 = 78 which is N.

the final output will be S L A N.

Code:

int ifEven(string str)
{
    string array[15];
    char something[]="ABCDEFGHIJKLMNOPQRSTUVWXYZ";
	int i=0;
	int k=0;
	
    while(i<str.size()-1)
    {
        array[k]=str.substr(i,2);
		cout<<array[k]<<" ";
		i+=2;
		k+=1;
	} 
   

}

**7stud** · 12-10-2005

Post your code. What have you got so far? What are your specific questions about some code you wrote in an attempt to solve your problem?

**gtr_s15** · 12-10-2005

thank you for your concern....

**jlf029** · 12-10-2005

what does this have to do with the function ifEven?

**gtr_s15** · 12-10-2005

well for my program, i need to split those integer into two each, tats mean 44 11 00 44, there are four size. so if it is odd, we add '0' at the back of it to make it two integer and convert it to char.
hope you undestand.

**pianorain** · 12-10-2005

Why don't you write an Encode and a Decode function instead of trying to encode the string by hand? Writing the Encode function should make the issues much clearer.

31080620170434194020195014201718041105

Thread: what is the error please? HELP??

Thread Tools

Search Thread

Display

what is the error please? HELP??