Thread: I need help please!

I am writing a basic game program to use as a reference later on. BUT if I try to use teh same variable in both it says multiple definitions, and if I dont init the variable it wont either. Here is what I am trying to do...
FIRST .CPP

Code:

#include "main.h"
#include "colors.h"
int a;
void mainmenu();
void charmenu();
int EXIT();
void options();
void newgame();
void loadgame();
//
int main()
{
	mainmenu();
	return 1;
}
void mainmenu()
{
	text_red;
	system("cls");
	cout << "****************\n";
	cout << "*(1) New Game  *\n";
	cout << "*(2) Load Game *\n";
	cout << "*(3) Options   *\n";
	cout << "*(4) Exit	  *\n";
	cout << "****************\n";
	text_darkgrey;
	cout << "Selection: ";
	cin >> a;
	cin.ignore();
	switch ( a ) {
		   case 1:
				newgame();
				break;
		   case 2:
				break;
		   case 3:
				break;
		   case 4:
				EXIT();
				break;
		   default:
				cout <<" Sorry but Please Input 1-4 please";
				cout <<" Press ENTER to continue";
				cin.get();
				mainmenu();   
				break;
}
}
//
int EXIT()
{
	system("cls");
	cout.flush();
	return (EXIT_SUCCESS);
}
//END OF EXIT

and just a test .cpp looks like this.

Code:

#include "main.h"
int a;
//the following are the diffrent programs within the mother program to make this game playable
void mainmenu();
void charmenu();
int EXIT();
void options();
void newgame();
void loadgame();
//end of menu setup//notice ALL menus except main and Exit are void
void newgame()
{
	 cout << "New Game Test Cout Function";
	 cin.get();
	 cin >>a;
	 cin.ignore();
	 cout <<"Test 2 you entered "<< a <<" as a number";
	 cin.get();
	 }

now the errors are

Code:

  multiple definition of `a' 
  first defined here  
  ld returned 1 exit status

I have tried not difing it in the newgame .cpp but it wont and defing it i get errors as well so what is wrong.

I dont know really an other way of rearranging my code (and what is wrong with the recursive call)??

Also thanks alot for the help, I knew I was forgetting something really simple lol

colors.h ?
i dont have that header file, anyone can upload or tell me a site where i can download these?

oh it is for the text_color function. here it is if you want it (You have to have <windows.h> included tho, as it is a windows function. here it is if you want it.

k thanks,

windows.h doesnt come with vc++ as well
upload that to?

EDIT: nvm i found it in a copy of dev c++

windows.h doesnt come with a microsoft compiler? how messed up is that.

yep it doesnt ^.^

It does work tho. It works the because it is the last function in the .cpp. so when it returns there is no other code for the program to execute so it will work.I have this code in all my programs just cuzz it is easier to adjust my code if my exit is not within the main program.

The fact that it is the last function defined in the cpp file means nothing. It only matters if it is the last function called. In your case, it would call system("cls") and cout.flush() when the user chooses option 4 to exit. However, as nvoigt said, the return (EXIT_SUCCESS) does nothing. The code that calls EXIT() doesn't use it's return value, and so it is ignored. The mainmenu() method finishes and control returns to main(), and then main() calls return 1.

If you check the exit code of your program, you will see that it is 1, not 0 (EXIT_SUCCESS is 0). So the screen is being cleared, but the return(EXIT_SUCCESS) is ignored.

OH, so it will exit the program with or without the return(EXIT_SUCCESS) right?

Yes.