Thread: problems running simple prog

Hi all, I am very new to c++, in fact I have only read a few beginners tutorials in the last 2 days, however... I do script for a game NWN which involves some c++ based programming although there are alot of similarities theres also alot of differences, Anyway I just thought I would experiment by creating a simple number guesssing game using the Dev-c++ compiler, the problem is that the program will not even run, could this be a bug or is it in the program I created?

Code:

////////////////////////////////////////////////////////////////////////////////
//:: Number guessing game
//:: First ever c++ program written by Scott Clarke
////////////////////////////////////////////////////////////////////////////////
#include <iostream>
using namespace std;
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses);
int main()
{
    int nNumIGuess = rand() % (1 - 10 + 1);
    int nYourNum;
    int nNumOfGuesses;
    cout<<"You have three guesses to work out which number I am thinking of ";
          "between 1 - 10. \nEach time you guess I will tell you if the number "
          "I am thinking of is higher or lower. ";
    while (nNumOfGuesses < 3)
    {      
        cout<<"\nGuess what number I am thinking of? ";
        cin.ignore();
        cin>>nYourNum;
        cin.get();
        NumberCheck(nNumIGuess, nYourNum, nNumOfGuesses);
    }
}
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses)
{
    nNumOfGuesses++;
    if (nYourNum < nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is higher";            
    }  
    else if (nYourNum > nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is lower";
    }
    else 
    {
        cout<<"\nCorrect!!!! You win";       
    }
    return nNumOfGuesses; 
}

Thanks for your time.
Scott

Code:

////////////////////////////////////////////////////////////////////////////////
//:: Number guessing game
//:: First ever c++ program written by Scott Clarke
////////////////////////////////////////////////////////////////////////////////
#include <iostream>
using namespace std;
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses);
int main()
{
    int nNumIGuess = rand() % (1 - 10 + 1);   // I'm not gonna fix it, but this rand function
                                              // will always return 1.
    int nYourNum;
    int nNumOfGuesses = 0; // You have to initialize this variable.
    /* Careful with your semicolons on multiline cout statements. */
    cout<< "You have three guesses to work out which number I am thinking of " <<
           "between 1 - 10. \n Each time you guess I will tell you if the number " <<
           "I am thinking of is higher or lower. ";
    while (nNumOfGuesses < 3)
    {      
        // You had alot of unnessasary cin statements in here.
        cout<<"\nGuess what number I am thinking of? ";
        cin>>nYourNum;
        NumberCheck(nNumIGuess, nYourNum, nNumOfGuesses);
    }
    cin.get();  // Trailing cin.get() cause Dev-Cpp closes when it returns a value
}
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses)
{
    nNumOfGuesses++;
    if (nYourNum < nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is higher";            
    }  
    else if (nYourNum > nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is lower";
    }
    else 
    {
        cout<<"\nCorrect!!!! You win";       
    }
    return nNumOfGuesses;

Here you go. Just fix the rand function. I'll leave it up to your logic.

Yes, I'm familiar with Dev-C++. Is it opening and closing real quick or is it not opening at all? Because if your not getting any compiler or linker errors, then the program should open.

Edit: Oh, if you copied my code exactly, then you'll get an error cause I didn't paste the last end brace by accident, I changed it now. If that wasn't your problem, then please answer my other question.

Hmm... check your Windows Task Manager and see if the program is open there. If it isn't then reboot or something.

Remove the rand() function from your program temporarily and try compiling that. Your cpu might be getting hooked on that function for some reason and that's why it's eating your cpu usage.

Edit: Dooohhh. I'm not thinking. We're returning the value of guesses, but we aren't updating the variable in main. Try compiling this;

Code:

////////////////////////////////////////////////////////////////////////////////
//:: Number guessing game
//:: First ever c++ program written by Scott Clarke
////////////////////////////////////////////////////////////////////////////////
#include <iostream>
using namespace std;
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses);
int main()
{
    int nNumIGuess;
    int nYourNum;
    int nNumOfGuesses = 0; // You have to initialize this variable.
    /* Careful with your semicolons on multiline cout statements. */
    cout<< "You have three guesses to work out which number I am thinking of " <<
           "between 1 - 10. \n Each time you guess I will tell you if the number " <<
           "I am thinking of is higher or lower. ";
    while (nNumOfGuesses < 3)
    {      
        // You had alot of unnessasary cin statements in here.
        cout<<"\nGuess what number I am thinking of? ";
        cin>>nYourNum;
        nNumOfGuesses = NumberCheck(nNumIGuess, nYourNum, nNumOfGuesses);
        cin.ignore();
    }
    cout << "You ran out of guesses.";
    cin.get();  // Trailing cin.get() cause Dev-Cpp closes when it returns a value
}
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses)
{
    nNumOfGuesses++;
    if (nYourNum < nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is higher \n";            
    }  
    else if (nYourNum > nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is lower \n";
    }
    else 
    {
        cout<<"\nCorrect!!!! You win \n";       
    }
    return nNumOfGuesses; 
}

Ok this is the whole program with working code on everything. If you have trouble with this then it's your computer. I compiled this on DevC++ and it works fine.

Code:

////////////////////////////////////////////////////////////////////////////////
//:: Number guessing game
//:: First ever c++ program written by Scott Clarke
////////////////////////////////////////////////////////////////////////////////
#include <iostream>
#include <stdlib.h>
#include <time.h>
using namespace std;
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses);
int main()
{
    srand((unsigned)time(NULL));   
    int nNumIGuess = (rand() % 10) + 1;
    int nYourNum;
    int nNumOfGuesses = 0; // You have to initialize this variable.
    /* Careful with your semicolons on multiline cout statements. */
    cout<< "You have three guesses to work out which number I am thinking of " <<
           "between 1 - 10. \n Each time you guess I will tell you if the number " <<
           "I am thinking of is higher or lower. ";
    while (nNumOfGuesses < 3)
    {      
        // You had alot of unnessasary cin statements in here.
        cout<<"\nGuess what number I am thinking of? ";
        cin>>nYourNum;
        nNumOfGuesses = NumberCheck(nNumIGuess, nYourNum, nNumOfGuesses);
        cin.ignore();
    }
    if(nYourNum != nNumIGuess)
        cout << "You ran out of guesses.";
    cin.get();  // Trailing cin.get() cause Dev-Cpp closes when it returns a value
}
int NumberCheck(int nNumIGuess, int nYourNum, int nNumOfGuesses)
{
    nNumOfGuesses++;
    if (nYourNum < nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is higher \n";            
    }  
    else if (nYourNum > nNumIGuess)
    {
        cout<<"\nIncorrect, the number I am thinking of is lower \n";
    }
    else 
    {
        cout<<"\nCorrect!!!! You win \n";       
    }
    return nNumOfGuesses; 
}